Submodules in the package are placed in different locations. They should follow a consistent pattern.
As modules like Entity API and Views use the modules directory to hold implementations on behalf of core modules, we should not use the modules directory to hold submodules. Instead, we should create a directory in the sparql directory for each module. For example, sparql/sparql_registry.
Change directory structure and add update function for existing installations.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | sparql_directory_move-1222066-7.patch | 2.34 KB | clayball |
| #3 | directory_structure_updated-1222066-03.patch | 15.8 KB | clayball |
| #2 | directory_structure-1222066-2.patch | 15.8 KB | clayball |
Comments
Comment #1
clayball commentedI'll make these changes and submit a patch for review.
Comment #2
clayball commentedI realize this has been tagged with 'discussion needed' but here's a patch anyhow :)
This seems like a good idea and makes sense to me. However, if there is a standard then we should follow it :)
Comment #3
clayball commentedsorry.. I just tested my patch on a different machine and realized the directories were not created and neither were the files that moved there.
Trying a new patch.
Comment #4
clayball commenteddang it.. the second patch didn't apply either. I must be missed something.
I git added the directories/files in the second patch thinking that would help.
Will look at this again tomorrow.
Comment #5
clayball commentedI can't seem to add a directory. Unassigning.
Comment #6
scor commentedDon't give up Clay :)
The best to roll a patch to move directories around is:
- create a disposable branch
git checkout -b 1222066-sparql-move-
git mv old/ new/-
git commit -m "- #1222066 by cwells73 | linclark: Changed Fix SPARQL package's directory structure."-
git format-patch -C -M HEAD~1(which will only record the file location changes, without their content).Don't forget to switch back to the regular branch when you are done with
git checkout 7.x-2.x.This is a simpler method than Advanced patch contributor guide which should work for this simple use case.
All what Lin will have to do is run git am to apply+commit the patch.
Comment #7
clayball commentedNever :) .. thank you! I figured the use of branches would play a role in this situation :)
Here's a patch!
Comment #8
Anonymous (not verified) commentedWorked for me, fixed with commit: http://drupalcode.org/project/sparql.git/commit/33bb42c
Thanks for the patch!
Comment #10
sun.core commented