OS: Mac 10.6.8
Browser: Chrome 14.0.814.0 dev (also tried a stable Chrome release)

Commit a39644f makes dreditor stop working entirely for me. When I check out the previous commit instead, it works normally.

Edit: Commit message says

Removed obsolete duplicate Drupal.attachBehaviors().
This was required before Dreditor injected itself into the page, since
Drupal's attachBehaviors() had no knowledge/access of the behaviors in the
user script, due to browser security realm restrictions.

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Commit a39644f makes dreditor completely nonfunctional » Do not invoke Drupal.attachBehaviors() twice
Category: bug » task
Priority: Major » Normal

http://drupalcode.org/project/dreditor.git/commit/5c0561dca46616a6374516...

Sorry for that. So looks like Chrome behaves differently (again)... :(

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I just committed #1136342: It's impossible to run unit tests due to return statement, which might explain the difference.

Would be beneficial to remove these lines here, since invoking all of the Drupal behaviors twice ain't good for performance.

andypost’s picture

andypost
he/him
Primary language Russian
commented

This troubles mostly caused by wrong written behaviuors in contrib modules.
So I think it's ok and makes contrib to fix their bugs ( for ex. #1576392: pifrResultAssertions prevents results from being expanded

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed

Somehow I cannot find the double invocation of Drupal.attachBehaviors() anymore, so this is obsolete. ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added text of commit message to be a little more helpful.