Views doesn't always check the return value of view::set_display() [#1222494]

In admin.inc, both views_ui_preview() and views_ui_edit_form() call set_display, but do not check to see if it returns FALSE.

I came across because the second conditional in view::build() wasn't working properly. The display handler is NULL, yet it continues to build.

Comment	File	Size	Author
#1	1222494-admin-set_display-check.patch	998 bytes	dawehner

Comments

German

commented 12 August 2011 at 21:03

Status:

Active

» Needs review

Status	File	Size
new	1222494-admin-set_display-check.patch	998 bytes

I'm wondering about a proper help message which should be used here?

Something like t('Invalid display id @display ?

Anyway here is a patch.

German

commented 10 September 2011 at 22:05

Status:

Needs review

» Fixed

Commited this patch, there might be other places but better have something then nothing.

24 September 2011 at 22:11

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.