femail ignores forum access

As a request to handle the issue, would it be possible to separate femail permissions into post/subscribe by roles?

* subscribe to forum (allows user to subscribe to forums to which they have access so they will receive posts by email)

* post to forum without approval (this would allow them to post to any forum that they have access by femail)

if the post permission is not granted, then emails sent to the forum address would remain in the content/comment queue as unpublished until a moderator approves them.

For public forums, this would allows only certain roles to have unrestricted posting privileges, while allowing a larger group to subscribe to the forum. i.e. authenticated users could subscribe to a forum but would not be able to post without approval. We had 2 users with non-standard "away" messages that got into one forum and started an auto-reply ping-pong match so would like to prevent that. RIght now femail permissions seem to grant subscribe and post (and override other foum grants)

Thanks for all your efforts -- the forums have worked wonderfully for our smaller private forums!

Thanks - will try it tonight! We do want posts to go into an unpublished queue so that we may moderate and change to publish. Hope it can get integrated as part of the official module !

I think the latter code is incorporated in the module now, but coded differently as only the forums that the user does have access to are available on the subscription page.

so far no luck - all topics and comments are being posted even though user does not have permission to create topics in the forum. Will take a closer look in the morning. Thanks!

Knew I should quite sooner last night -- forum permission was allowed :-)

This is working now !!!! (with check to see if forum_access is loaded)
All new topics where user does not have access (either femail or forum permission denied) are set as unpublished nodes.

Remaining issues:
I have found that changing the node to publish make the node appear in the forum, but does not to trigger femail to distribute the node. Editing it, and clicking publish box and saving does trigger the email.
author is original user in the forum, but is sent by femail with sender as the admin who published the node. (would be nice to keep the original senders email as in the forum)

Comments are going into the forum even though user doe not have post without approval AND the approval queue, but not out by email at least)

Thanks to all!!!
Merlise

 if(!user_access('post by femail')){
    // Add a message to the logs so that we know we received a message and that
    // it hasn't been published
    watchdog('femail', 'Message "@subject" FROM "@email" has been posted, but unpublished', array(
      '@subject' => $msg['title'],
      '@email' => $msg['from']
    ), WATCHDOG_INFO);
    $comment_status = 1;
    $node_status = 0;
  }
  else{ 
   // user allowed to post by femail

   // if forum_access loaded  verify forum permissions
    if (module_exists('forum_access')) {
	$emails = variable_get('femail_emails', array());
   	$tid = array_search($msg['to'],$emails);
       // check the 'create' permission
    	$allowedToCreate = forum_access_access($tid, 'create', $user);

	if (!$allowedToCreate) {
	  $comment_status = 1;
   	  $node_status = 0;
    // Add a message to the logs so that we know we received a message and that
    // it hasn't been published
    watchdog('femail', 'Message "@subject" FROM "@email" has been posted, but  unpublished', array(
      '@subject' => $msg['title'],
      '@email' => $msg['from']
    ), WATCHDOG_INFO);
   }}
   else {
    	$comment_status = 0;
    	$node_status = 1;
	}
  }
  
  // If the in-reply-to is set, then we need to create a comment else we need to
  // create a node, or creating a comment has failed as the msgid could not be
  // found.
  if(isset($msg['in-reply-to']) || strtolower(substr($msg['title'], 0, 3)) == 're:'){
     if(_femail_post_comment($msg, $user, $comment_status)){return;}
  }
  // else we need to create a node, or creating a comment has failed as the 
  // msgid could not be found.
  _femail_post_forum_topic($msg, $user, $node_status);
}

If I update the status of a node to published in the Administer-> Content Management -> content
I observe the following

in femail_nodeapi (in femail.module)

$op is 'update' (correct), but $forum_tid is null so no message, but node does appear in the forum

If I edit the node (as admin) and save it, the $op is 'alter' and forum_tid is set, and thus the email goes out.

using 1.9 (actually same site :-)

1.9 fixes the problem in http://drupal.org/node/1220300 so if forum permissions and femail permissions are granted email does go out as expected now. (Thanks!)

If the user has femail permission but not forum permissions, the topic is unpublished with the fixes above. (that works now!)

Issue 1) node seems to be missing the taxonomoy terms after updating the status to publish so the forum_tid is null. Editing and updating the status to publish and saving does update the taxonomy ?? so forum_tid is set, and femail does distribute the topic.

Issue 2) comments are ignoring the forum permission (probably the same checks need to be made?), so appear in the forum when they should be in the comment approval queue. (but are not sent by email (half right).)

Updating their status in the comment approval queue does trigger femail to distribute them, so the behaviour for "publishing" a comment is not the same as publishing a node.

Issue 2 is more critical as we do not want posts to appear without approval, while Issue 1 requires more work on the moderators part.

Thanks!
Merlise

comment_status = 1 is unpublished, so comment needs approval before publishing.

I've verified that the allowedtoCreate is false, so comment_status should be 1 and node_status = 0, which results in the following actions

* comment "appears" in forum (wrong)
* comment is in comment approval queue as unpublished (correct)
* watchdog indicates that comment needs approval
* femail does not distribute the comment (correct)

m