- disable rules when dependent modules are disabled, and enable them again afterwards
- mark rules as broken so the UI can properly deal with them (mark them, but don't deal with them. show missing dependency.)
- allow deleting broken rules

Should we deal with rules that have a failing integrity-check similarly?

CommentFileSizeAuthor
#4 rules_dependencies.patch23.88 KBfago
#2 1223028-rules-dependencies.patch9.75 KBklausi
#1 1223028-rules-dependencies.patch7.93 KBklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Component: Rules Core » Rules Engine
Status: Active » Needs review
StatusFileSize
new 1223028-rules-dependencies.patch7.93 KB

Here is a patch:
* Adds a rules_dependencies table to track dependencies
* Adds a db column "dirty" to rules_config to track broken configurations
* Adds a "dependencies" property to Rules configurations on load
* uses hook_modules_disable/enable() to update the "dirty" flag
* Adds a RulesDependencyException

TODO:
* Mark configs as dirty during execution
* Don't execute dirty configurations
* Display dirty configurations properly in the UI
* Tests

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
StatusFileSize
new 1223028-rules-dependencies.patch9.75 KB

Some progress, but I'm not sure if this is the right way.
integrityCheck() now sets the dirty flag. Reaction rules that execute a dirty component are now marked as dirty, too.

TODO:
* how many dirty states do we need? only one?
* all other TODOs from above

fago’s picture

fago
Primary language German
Location Vienna
commented 
+        'description' => 'Indicates broken configurations. 0 = OK, 1 = missing dependency, 2 = failed integrity check.',

Let's use a single dirty state + have exceptions tell why it is dirty when integrityCheck() is called. With the dependencies() information now loaded into the entity object, this approach should be good to go.

Perhaps we should clean up the exception handling first though.

fago’s picture

fago
Primary language German
Location Vienna
commented
StatusFileSize
new rules_dependencies.patch23.88 KB

ok, I finished the patch + added tests. Works for me.

Todo: Implement UI changes, i.e. show in the admin UI when rules are failing, including the error message.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

ok, I've improved the UI to work better for configurations having error + added in displaying of error messages.

Attached patch works for me -> committed.

Automatically closed -- issue fixed for 2 weeks with no activity.