Download & Extend
Issues

Update for ripping out textgroup support in Drupal locale module

Posted by Gábor Hojtsy on July 19, 2011 at 4:02pm
Project:Drupal core
Version:8.x-dev
Component:language system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (duplicate)
Issue tags:D8 upgrade path, D8MI, language-config, language-ui

Issue Summary

Based on discussion in #1188430: Rip out textgroup support from locale module, we need to postpone the commit of the update function to ensure it gets "tested" = run in a test update. However, the functionality removal is pretty important to make happen soon because lots of other work depends on it being gone. We don't want to spend time tossing around code that is going to be removed in refactorings. Read the full discussion in #1188430: Rip out textgroup support from locale module.

Postponing this one on #1182290: Add boilerplate upgrade path tests.

Parent issue

#1260628: META: Better translation management API in locale module

Change records for this issue

Login or register to post comments

Comments

#1

Posted by Gábor Hojtsy on July 19, 2011 at 4:04pm

Patch.

AttachmentSizeStatusTest resultOperations
update_for_textgroup_removal.patch851 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch update_for_textgroup_removal.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details | Re-test

#2

Posted by Gábor Hojtsy on July 19, 2011 at 4:04pm

#3

Posted by Gábor Hojtsy on August 9, 2011 at 8:04am

#1188430: Rip out textgroup support from locale module got committed, #1182290: Add boilerplate upgrade path tests still outstanding.

#4

Posted by c960657 on November 21, 2011 at 9:14pm
Status:postponed» needs review

Reroll of Gabor's patch. I suspect this issue is what is causing the test bot to barf on my patch for #746240: Race condition in locale() - duplicates in {locales_source}.

AttachmentSizeStatusTest resultOperations
update_for_textgroup_removal-2.patch967 bytesIdleFAILED: [[SimpleTest]]: [MySQL] 33,987 pass(es), 2 fail(s), and 1 exception(es).View details | Re-test

#5

Posted by c960657 on November 21, 2011 at 9:40pm
AttachmentSizeStatusTest resultOperations
update_for_textgroup_removal-3.patch992 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/locale/locale.install.View details | Re-test

#6

Posted by System Message on November 21, 2011 at 10:37pm
Status:needs review» needs work

The last submitted patch, update_for_textgroup_removal-3.patch, failed testing.

#7

Posted by c960657 on November 22, 2011 at 10:02pm

I think the test bot problem is due to #1336170: Add locale module to upgrade tests.

#8

Posted by Gábor Hojtsy on November 24, 2011 at 9:36am

@c960657 you are right. I've just posted a combined patch at http://drupal.org/node/1336170#comment-5285748 to prove that it fixes the issue (apart from manually going through all the schema details and confirming it is equal to D7). I think the update itself will be committed here, I just cross-posted there for testing, so keeping this open.

#9

Posted by Gábor Hojtsy on November 25, 2011 at 7:01am
Status:needs work» needs review

#5: update_for_textgroup_removal-3.patch queued for re-testing.

#10

Posted by Gábor Hojtsy on November 25, 2011 at 7:03am
Status:needs review» closed (duplicate)

Ha, this was committed as part of #1336170: Add locale module to upgrade tests already.

#11

Posted by Gábor Hojtsy on January 26, 2012 at 5:55pm
Issue tags:+language-base

Tagging for base language system.

#12

Posted by Gábor Hojtsy on February 6, 2012 at 11:22am
Issue tags:+language-ui

Adding UI language translation tag.

#13

Posted by Gábor Hojtsy on February 6, 2012 at 11:23am
Issue tags:-language-base

Language-base is not applicable here.

#14

Posted by Gábor Hojtsy on February 7, 2012 at 11:56am
Issue tags:+language-config

Tagging for config leg of D8MI.