Closed (won't fix)
Project:
Porter Algorithm Search Stemmer
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Feb 2007 at 22:55 UTC
Updated:
25 Nov 2007 at 22:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
m3avrck commentedDoesn't appear to be in a patch format... http://drupal.org/patch
Comment #2
shadyman@erroraccessdenied.com commentedComment #3
Christefano-oldaccount commentedHere's a patch. The only change I made was removing
?>from the last line.Comment #4
ray007 commentedsubscribing
Comment #5
Christefano-oldaccount commentedComment #6
tanoshimi commentedsubscribing
Comment #7
jeffomac commentedsubscribing
Comment #8
gregglesI believe that the version of this module in HEAD currently works with Drupal5. I'm running it on two sites and it's fine in my testing. You can download it here http://drupal.org/node/95939
I plan to branch that and make releases for it shortly.
This patch adds a hook_help implementation (great!) but also reformats a bunch of code which makes it hard to review. I think the only piece of this patch that deserves to be applied is the hook_help and the rest of it can/should be ignored.
@figaro and @christefano - can you clarify why you feel the other changes are needed?
I believe that Steven used the formatting he did because this code comes from another project. So, if we leave the formatting the way that they use it then it makes it easier to update if/when they update their code. I don't plan to change any of the formatting of that code.
Comment #9
Christefano-oldaccount commentedI rolled the patch to help get a stable release out, but I'm fine with any stable release of this module. Thanks for your help, greggles.
Comment #10
gregglesI created a 5.x development release which should show up in a few hours. If we have a few weeks of that module without reports of issues then I'll create a 1.0 release.
I don't see much reason to add the help docs (they add links to admin/by-module but don't really provide additional information) and figaro hasn't clarified any of the other changes, so I'm changing this to "won't fix".