Porterstemmer update for 5.x branch
figaro - February 24, 2007 - 22:55
| Project: | Porter-Stemmer |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Description
Has no porterstemmer_help function and better following of coding conventions.
| Attachment | Size |
|---|---|
| porterstemmer.patch | 9.07 KB |
#1
Doesn't appear to be in a patch format... http://drupal.org/patch
#2
#3
Here's a patch. The only change I made was removing
?>from the last line.#4
subscribing
#5
#6
subscribing
#7
subscribing
#8
I believe that the version of this module in HEAD currently works with Drupal5. I'm running it on two sites and it's fine in my testing. You can download it here http://drupal.org/node/95939
I plan to branch that and make releases for it shortly.
This patch adds a hook_help implementation (great!) but also reformats a bunch of code which makes it hard to review. I think the only piece of this patch that deserves to be applied is the hook_help and the rest of it can/should be ignored.
@figaro and @christefano - can you clarify why you feel the other changes are needed?
I believe that Steven used the formatting he did because this code comes from another project. So, if we leave the formatting the way that they use it then it makes it easier to update if/when they update their code. I don't plan to change any of the formatting of that code.
#9
I rolled the patch to help get a stable release out, but I'm fine with any stable release of this module. Thanks for your help, greggles.
#10
I created a 5.x development release which should show up in a few hours. If we have a few weeks of that module without reports of issues then I'll create a 1.0 release.
I don't see much reason to add the help docs (they add links to admin/by-module but don't really provide additional information) and figaro hasn't clarified any of the other changes, so I'm changing this to "won't fix".