In IE6, the there is extra spacing between menu items. This problem does not exist in Firefox 1.5

I'm not sure whether this is a CSS issue or a templating issue, but assume it's CSS.

I have attached a screenshot of what it looks like in IE6.

CommentFileSizeAuthor
#5 style.css_.patch1.49 KBjulianna
#1 bb-ff.jpg6.45 KBjulianna
bb-ie.jpg6.65 KBjulianna

Comments

julianna’s picture

StatusFileSize
new6.45 KB

I have attached what it looks like in Firefox 1.5

julianna’s picture

Assigned: Unassigned » julianna
Status: Active » Reviewed & tested by the community

I was able to fix the problem by replacing this:

/* lists, menu */

ul, ul.menu, .item-list ul {
  margin: 0 0 .5em 0;
  padding: 0 0 0 0.5em;
}

ul li, ul.menu li, .item-list ul li {
  margin: 0 0 0 1em;
  padding: 0;
  list-style: circle url(images/menu-leaf.gif);
}

ul li.expanded, ul.menu li.expanded, .item-list ul li.expanded {
  list-style: disc url(images/menu-expanded.gif);
}

ul li.collapsed, ul.menu li.collapsed, .item-list ul li.collapsed {
  list-style: square url(images/menu-collapsed.gif);
}

ul.menu li ul li {
  font-size: 95%;
}

ul.menu li ul li ul li {
  line-height: 1.6em;
}

with this (pulled from the Garland theme):

ul li, ul.menu li, .item-list ul li, li.leaf {
  margin: 0.15em 0 0.15em .5em;
}

ul li, ul.menu li, .item-list ul li, li.leaf {
  padding: 0 0 .2em 1.5em;
  list-style-type: none;
  list-style-image: none;
  background: transparent url(images/menu-leaf.gif) no-repeat 1px .35em;
}

ul li.expanded {
  background: transparent url(images/menu-expanded.gif) no-repeat 1px .35em;
}

ul li.collapsed {
  background: transparent url(images/menu-collapsed.gif) no-repeat 0px .35em;
}

ul li.leaf a, ul li.expanded a, ul li.collapsed a {
  display: block;
}

This code should be included in the next update for the theme.

Thanks.

Tobias Maier’s picture

Status: Reviewed & tested by the community » Needs work

Hello julianna,

welcome at drupal and thank you for your first patch.

the first status is patch (code needs review)
and then someone hast to review the code.
as soon as other people think that the code is good to go the issue gets the status patch (ready to be commited)

btw. please create a proper patch --> patch (code needs work)

Thank you

Tobias

julianna’s picture

Hi, Tobias.

Thanks for letting me know the next step. Unfortunately, I read through much of the patch documentation and it is more cryptic than Greek to me. I think I'll need to do much reading on CVS in general before I create a patch.

Julianna

julianna’s picture

Assigned: julianna » Unassigned
StatusFileSize
new1.49 KB

Okay, I think I finally figured out this patch thing.

I'm leaving the status at "code needs work". Although the patch fixes the spacing issue, it moves the Primary Links boxes down a bit. This isn't an issue for me because I don't use the Primary Links but, obviously, this won't work for everyone.

Steel Rat’s picture

Why do a patch for a theme instead of just correcting the theme? I'm confused.

julianna’s picture

Because I'm a newb and don't know what I'm doing?

itapplication’s picture

Status: Needs work » Closed (won't fix)