It would be great if the 'Create commit message' button provided the whole git operation including the proper author attribution. For instance, git commit --author="dstol <dstol@329570.no-reply.drupal.org>" -m "- #[issue] by dstol [message]

The patch will need to be created with git format-patch and I don't think there is an easy way grab the user's email at the moment but it would still would be a nice feature to have in the future.

Comments

sun’s picture

boombatower’s picture

sub

tim.plunkett’s picture

Just a heads up, the menu callback changed since the patches in that issue, its now http://drupal.org/user/54136/git-attribution, which gives {"author":"sun \u003csun@54136.no-reply.drupal.org\u003e"}

dawehner’s picture

Status: Active » Needs work
StatusFileSize
new960 bytes

Here is a first start to implement that.

I'm wondering whether the author tag should be appended or added to a second textfield.
If it's added to the first field it would maybe make sense to rename it to "git commit snippet" or something similar and adapt it a bit more.

sun’s picture

Status: Needs work » Fixed
StatusFileSize
new37.82 KB
new7.01 KB

Committed attached patch. :) And this is how it looks like:

dreditor-git-command-attribution-widget.png

dave reid’s picture

Why git commit -a?

tim.plunkett’s picture

Can we PLEASE remove the -a in there? That is scary and not at all a safe default.

tim.plunkett’s picture

Status: Fixed » Needs review
StatusFileSize
new588 bytes

Trying to be helpful instead of yelling :)

dave reid’s picture

Status: Needs review » Reviewed & tested by the community
sun’s picture

Status: Reviewed & tested by the community » Fixed

Alrighty, committed the follow-up with an additional comment.

rfay’s picture

Wow, SOOO sweet!

ericduran’s picture

this is awesome :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.