I tried the HEAD version of this module to get the 'diff' link working that is given by the excellent recent changes module. Unfortunately the links like: /node/6/revisions/view/132/133 give a 'page not found' error. And the diff radio buttons do not appear in node revisions tab.

I know this is HEAD, but I like this functionality a lot. And Roetzi got it to work: http://test.tschannen.net/recent_changes
Does it have anything to do with: http://drupal.org/node/114822 ?
Reading that issue it looks to me to be a permission problem, not a patch to get the new diff module to work.

I did 'uninstall' the old diff module and re install the new version (to make sure the diff.install file was run). Do I need to delete some fields from the variables table ?
I'm running drupal 5.1, php 4.4.4. Apache/1.3.37 (Unix) , MySQL database 4.1.21

Comments

koorneef’s picture

koorneef commented

Amazingly, the diff module reported something like: "The diff module now has module weight 1 and you can use it to review revisions" in green text when I was on the /admin/logs/status page of my site. Now the module works perfectly.

I don't know why the status page triggered the diff module into action, but maybe that can be fixed. I expected to see this message on the admin/build/modules page.

I'm really having fun with the new diff and "recent changes" modules ! great work !

rötzi’s picture

rötzi commented

It shows on the admin page because this page triggers the "hook_requirements" hook, in which the check of module weights is done. It should have been done at the installation of the diff module too though.

Maybe the install was not run properly since you had it alredy installed.

How did you uninstall the old version? Just disabled the module in the modules list (which is not enough because it just disables the module) or did you remove the entry from the database (which makes drupal run the install file when you enabled it again)?

koorneef’s picture

koorneef commented
Status: Active » Closed (fixed)

Thanks for the quick reply.
I disabled the module in the module admin listing page. So I didn't delete any values in the database. That can explain the fact that the db update didn't take place when I re-activated the diff module.