Move the file entity forms to project/file_entity

Since the file_entity module is sorta like the new file module, we should move over all the UIs for managing files. It seems like a good idea since node CRUD screens are stored in node, taxonomy CRUD in taxonomy, etc.

So w'll do two things:

• Move media/%file, media/%file/edit, etc to file_entity.
• Move over permissions.
• Write an update function to fix the permissions callback.

The following patch moves basic file operations out of the Media Module and into File Entity module. Viewing, editing, deleting files is now handled by File Entity.

I missed hook_permission(). Rolling new patches.

A few small typos, etc.

+++ b/file_entity.installundefined
@@ -219,3 +219,17 @@ function file_entity_update_7101() {
\ No newline at end of file

fix..

+++ b/file_entity.pages.incundefined
@@ -0,0 +1,192 @@
+ */

add a newline here?

+++ b/file_entity.pages.incundefined
@@ -0,0 +1,192 @@
+  if (!user_access('administer files') && (file_uri_scheme($file->uri) === 'private')) {
+    return MENU_ACCESS_DENIED;

This can be a followup, but shouldn't this be part of the access callback.

+++ b/file_entity.pages.incundefined
@@ -0,0 +1,192 @@
+/*  $form['#attached'] = array(
+    'css' => array(drupal_get_path('module', 'media') . '/css/media.css'),
+  );
+
+  // Not sure about this class name, seems to indicate the style.
+  $form['#attributes']['class'][] = 'media-image-left';
+  $form['#attributes']['class'][] = 'media-edit-form';

Why add this commented stuff?

+++ b/file_entity.pages.incundefined
@@ -0,0 +1,192 @@
+
+

less spaces?

oops. My last file-ops-file-entity1224788.patch file was missing the new file file_entity.pages.inc. It is included with this patch.

We found that Media sets some defautls like gruning on View modes for each file type which File Entity does not do...yet. That's for another issue to solve and won't be a part of the current patches.

New version of each patch. Minor clean up plus added hook_admin_paths to file_entity.

This is good to go. One little bug which Robin knows about and is fixing. Otherwise tested.

Committed to both modules:

Media: 5685d5c

File Entity: 555650a

this checks that the perm exists before continuing, throwing a recoverable error otherwise.

see related issue at #1290634: Install view file permission to all roles by default.

oops; forgot to renumber the update_N properly.

handle the admin perms here too as well, rather than in file entity. (file entity may be installed w/o media).

here's the real patch. rtbc by robeano irl

and committed.