The set of flags provided with the module has country codes in icon names, while there should be language codes. And the sizes are mostly 16x11 (with some exceptions), while the default configuration suggests 16x12.
See the corrected icon set in the attached file (all icons have language codes in the names, all sizes are 16x11). Due to the restrictions on the file types in this bug tracker I had to rename my flags.tar.gz file to flags.tar.gz.png, please rename it back and then unpack.
And please set the default size of icons to 16x11.
Thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| flags.tar_.gz_.png | 23.03 KB | yasenp |
Comments
Comment #1
giorgoskSome flags are missing from your package,
I guess you only included what needed changing ?
thus we are supposed to just drop them it the existing flags folder and let it overwrite the older files ?
Comment #2
yasenp commentedPlease tell me which are missing. I think included all of them. I have renamed them semi-automatically, so I could do some mistakes. I took /etc/gdm/locale.conf from Linux, extracted pairs "country -> language" from there and transformed them into bash script. Since there where many duplicates, I removed them manually, trying to choose the "main" country for each language.
Comment #3
giorgoskI could be mistaken but here is my thought
localizer has 246 flags
you only provide 56 flags
according to w3.org there are 136 languages http://www.w3.org/WAI/ER/IG/ert/iso639.htm
the drop down menu in locale add language provides 176 languages (admin/settings/locale/language/add)
something is wrong here
Comment #4
yasenp commented> localizer has 246 flags
Okay, there are 246 countries
> you only provide 56 flags
To be precise 58.
> according to w3.org there are 136 languages http://www.w3.org/WAI/ER/IG/ert/iso639.htm
> the drop down menu in locale add language provides 176 languages (admin/settings/locale/language/add)
Yes, but many languages are not a "title" language in any country.
Would you like to provide the same flag for several languages? I don't think it's a good idea.
Many languages correspond to some geographical regions inside countries, and these regions often have their own flags, and that would be fine to use them for those languages, but this is much bigger work that I can contribute now. I leave this to other contributors :)
> something is wrong here
Many countries use the same language. Some countries use many languages. This is a many-to-many correspondence, a set of pairs {(country, language)}. I state that the maximum size of the one-to-one subset (with unique countries and unique languages) is 58.
Comment #5
Roberto Gerola commentedI'll make some clean-up in the directory images, using only the Drupal languages code.