Bugs:

1. Displaying diff for previous revision instead of choosen one.

2. In meta block displaying username of page creator instead of revision creator.

3. Misspell in class name in legend.

CommentFileSizeAuthor
#3 diff.theme.inc.zip2.53 KBdlnsk
diff.theme.inc.patch983 bytesdlnsk
diff.module.patch946 bytesdlnsk

Comments

dlnsk’s picture

dlnsk commented

This may be related to the problem #1212402: Second "view changes" shows still first diff.

realityloop’s picture

realityloop commented
Status: Active » Postponed (maintainer needs more info)

Can you please confirm that the dev release doesn't suffer these issues, there are a substantial amount of patches that have been applied in dev, I'm just waiting for feedback before packaging a stable release.

dlnsk’s picture

dlnsk commented
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new diff.theme.inc.zip2.53 KB

I didn't install dev version but looked in sources. It seems like only item 2 didn't fixed.
Fixed file (from dev) attached.

realityloop’s picture

realityloop commented
Status: Active » Needs work

Could you please update the title to reflect what the change is supposed to be doing and what bug you believe it fixes?

realityloop’s picture

realityloop commented
Status: Needs work » Closed (cannot reproduce)

Checked locally and confirmed that "2. In meta block displaying username of page creator instead of revision creator." is is already happening in dev.

dlnsk’s picture

dlnsk commented
Title: Patches which fix number of existing bugs » In meta block displaying username of page creator instead of revision creator
Version: 6.x-2.1 » 6.x-2.2
Status: Closed (cannot reproduce) » Needs work

Item 2 isn't fixed!
See blame: http://drupalcode.org/project/diff.git/blame/a90aca03fd80d76a64a941163fa...
at line 289

mitchell’s picture

mitchell commented
Status: Needs work » Closed (works as designed)
Issue tags: -+patch

In the 7.x-3.x branch, the second patch appears to be committed, and the first patch appears to not apply anymore because it's commented.

If this issue persists, please reopen for the latest 7.x branch. Then a backport can be addressed.