Would it be possible for the image module to handle revisions? One of the nice features I like about the module is that we can use the inline image filter to link to image nodes, and when the image node itself is updated or revised, the new image automatically is inserted in all appropriate places where it is linked.

Comments

drewish’s picture

drewish commented
Status: Active » Closed (won't fix)

i think this is a won't fix due to limitations in drupal's files table schema. it makes it all but impossible to support different files on different revisions. i managed to get this working for the audio module by adding it's own files table but at this point i really don't think it was worth the trouble.

hbfkf’s picture

hbfkf commented

Please excuse me if I am saying something silly. But ordinary attachments (module Upload) are revisioned, which from my (ignorant) outsider point-of-view seems to contradict

it makes it all but impossible to support different files on different revisions

(Also, it looks to me that you are somehow using module Upload to manage the image and its derivatives, right? At least, the images and additional uploads are listed in the same list on the node's Edit page under "File attachments".)

(I am using Drupal 5.1 with module Upload version 5.1.)

drewish’s picture

drewish commented
Status: Closed (won't fix) » Active

humm, okay i'll take a look at that when i get a little time. i might have been missing somethign.

coltrane’s picture

coltrane
he/him
commented

Dragging this back into focus and also subscribing. 6.x-1.x-dev doesn't have support for revisions either so maybe development there would be best?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

Sorry, 5.x-1.x won't see any new features.

jonathan_hunt’s picture

jonathan_hunt commented
Category: feature » bug
Status: Closed (won't fix) » Active

I'm opening this as a bug. I just got burned by the lack of handling of revisions in Image module. I have a View that includes a filter on original filename. It wound up missing any image nodes that had been edited after initial upload because the image node vid is incremented but the file vids are not.

I'm assuming the issue is in image_update(). There doesn't appear to be a logic path when the image node is updated without affecting the files.

I can understand it being a feature request if image was to support revisions (i.e allow different images to be attached for different node versions). However, I regard it as a bug if Image doesn't bump the file versions to match the node versions. If my understanding is correct then Image needs to (a) either honour node version changes or (b) ensure revisions are not enabled on image nodes (i.e via a warning in the documentation).

From what I can see in the code, I suspect this issue exists for 5.x-2.x also.

joachim’s picture

joachim commented
Version: 5.x-1.x-dev » 6.x-1.x-dev

Needs to be fixed it on 6 first, then backported.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: bug » feature
Status: Active » Closed (won't fix)

Nothing happened for more than one year, and given that we're close to a D7 release, I'm going to mark this won't fix.