Closed (fixed)
Project:
Context Respect
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
22 Jul 2011 at 14:19 UTC
Updated:
23 Oct 2012 at 01:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
kevinwal commentedThanks Kevin, Looking now.
Comment #2
pwall commentedThis looks like an issue with the latest version of context layout. Checking against context layout changes.
Comment #3
mortendk commentedi can confirm this critical error
Comment #4
ngmaloney commented@kevinwal Please let me know if I can be of assistance. I'm fairly knowledgeable with the inner-workings of both this module and the Context API.
Comment #5
pwall commentedI've given you maintainer access to the project, thanks.
Comment #6
pbfleetwood commentedOuch.I've also found that disabling Context Respect brings the contexts back;however, it's broken something to do with the regions. Using either the Context module or the core block management, it used to be that if there were no enabled blocks in a region, the region would be disabled, and the page division (at least in the Zen theme) would have the appropriate class (one-sidebar, sidebar-first, no-sidebar, etc.). Now, this is no longer true. One would have to disable the regions in the contexts, which would mean that, in order to have the same flexibility that one had before this problem, one might have to add additional contexts. I have to restore my server because of this. Major bummer. :(My mistake: I had the Show All Regions option turned on in the Context settings.I would really like to see this module working with the latest version of Context; it is sorely needed.
Comment #7
jorditr commentedI add my interest to have that module working. If all the blocks of the site are activated through context, using the "Context Respect" module just makes all the configurations invisible to any user except the admin (UID 1) user. It's obvious that overpassing all the permission system the blocks are visible, so probably that's the problem...
Despite that, thanks for your uber-useful module :-)
Comment #8
kevinquillen commentedpwall, here is a patch. I changed the check_role_match() function to return TRUE if no roles are set on the block. This is a more user friendly change for people who drop Context Respect into an existing site, to let them gradually add role visibility instead of hide everything outright.
This fixed the issue for me, I tested it as anonymous and tried no role set (blocks showed), to anonymous role set (block showed), to admin roles set (blocks did not show for anon).
I would be more than happy commit to project dev if you gave me access.
Comment #9
kevinquillen commentedComment #10
kevinquillen commentedTested and pushed to 7.x-1.1.
Comment #11
kevinwal commentedComment #12
jorditr commentedHi, I've been waiting for that solutions for several months to be applied on a site I'm building. I left that issue on hold and now I've tried to upgrade Context Respect. I read that the 1.1 version has incorporated that feature, and after adding it to my site I see it doesn't work. I've read the patch provided on #8 and it looks to be there, but the module didn't worked for me after uploading it a couple of times more, rebuilding caches and so on.
Finally I decided to upload the last "dev" (april 24) version and then it really has worked. So, I'm afraid it's a confusion somewhere on the code and the current "1.1" (april 23) doesn't work properly and the "dev" version does.
In any case, despite the requested functionallity works as expected it throws some PHP warnings on pages that should show blocks that on a certain role are hidden (when we access those pages with roles no authorized on the block roles tab). And the message is:
Notice: Undefined variable: role_match en context_respect_reaction_block->check_role_match() (línea 108 de /usr/home/decidess.com/web/sites/all/modules/context_respect/plugins/context_respect_reaction_block.inc).It's a warning that I've solved finnishing "protected function check_role_match($block)" with:
Instead of just "return $role_match;". I don't know if it's of any help. I don't know why it's happenning to me and anybody else has complained about it? Probably the reason might be because of my hosting provider configuration. I don't have a bad hosting provider so it's likely that sooner or later anyone else is going to have the same trouble.
I've reopenned that issue just to give it visibility. I've been many months waiting the module (basic on my toolbox, so, many, many thanks for it) and observing it was not functional yet. I think it's almost close but not properly explained :-)
Comment #13
kevinquillen commentedThanks. I will review and get it in this week. For some reason I quit getting updates in this queue.
Comment #14
kevinquillen commentedI want to say that in the dev version, this definitely works. I am releasing a new version soon that fixes the other issue here #1754716: After installation the Context blocks disappear.
As of now, I can no longer duplicate this issue.