Download & Extend
Issues

$closure variable was removed, but is still being assigned in template_preprocess_maintenance_page()

Posted by Mark Theunissen on July 23, 2011 at 8:50am
Project:Drupal core
Version:8.x-dev
Component:theme system
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7

Issue Summary

The $closure was replaced by $page_bottom, see http://drupal.org/node/254940#closure

However in the function template_preprocess_maintenance_page() it is still being assigned:

$variables['closure']           = '';

This is confusing as it's not mentioned anywhere else in the code. Patch removes it.

Login or register to post comments

Comments

#1

Posted by Mark Theunissen on July 23, 2011 at 8:50am
AttachmentSizeStatusTest resultOperations
remove_closure-1227426-0.patch606 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 33,580 pass(es).View details

#2

Posted by Damien Tournoud on July 23, 2011 at 1:01pm
Status:needs review» reviewed & tested by the community

#3

Posted by webchick on July 28, 2011 at 8:25pm
Status:reviewed & tested by the community» fixed

Oops. :P

Committed and pushed to 8.x and 7.x. Thanks!

#4

Posted by System Message on August 11, 2011 at 8:31pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here