The manage group subscriptions tab (on the user's page) should only list those groups that the user is a member of, or should indicate the membership status for that user in the group.

Right now, I see all the groups on the site listed an its not clear which groups the user is a member of.

it'd be even nicer to be able to join and leave groups from this page.

Comments

kyle_mathews’s picture

kyle_mathews commented
Status: Active » Postponed (maintainer needs more info)

Are you sure you're seeing groups there that you're not member of? The query only pulls in groups the user is member of so please double check that.

dmgenesys’s picture

dmgenesys commented

Kyle, I was about to report this issue when i saw this post. Yes - it shows Manage Group Subscriptions for a user who is looking at the tab. So, this presents a problem - 1) administrator cannot modify subscriptions for a user 2) if permissions for administering subscriptions are given to authenticated users they mistakenly might attempt to change subscription settings for a peer while in fact changing their own.

To me this is a bug that needs to be addressed. Otherwise (since this is my first post here) - Thank You for a great module!

tobias’s picture

tobias commented

I am having this problem too. What's actually happening is it is displaying the groups the logged in user is subscribed to and not the groups for that other user. Hope this makes sense. :)

Put another way: user 1 looks at user/2/og_mailinglist - sees what he'd see at user/1/og_mailinglist or at og_mailinglist/subscriptions.

Would be handy to fix this bug. THanks! :)

Cheers,

Tobias

Shai’s picture

Shai commented

I'm confirming that I have the same problem. If I want to administer group subscriptions for someone other than me, I have to log in as that person (I use the Devel module for that).

Shai

kyle_mathews’s picture

kyle_mathews commented
Status: Postponed (maintainer needs more info) » Needs review

I pushed up a commit which seems like it fixes this issue (http://drupalcode.org/project/og_mailinglist.git/blobdiff/45945731b48c46...)

If a few of you could test the fix and report back that'd be great!

tobias’s picture

tobias commented

Hi Kyle,

Sorry, I missed this update of yours to this issue. I have tried to apply the patch but it does not work for me with the version of og_mailinglist I have from last year. Which version should I be updating to in order to try this out?

Cheers,

Tobias

kyle_mathews’s picture

kyle_mathews commented

@tobias -- you'll want to try the dev version of the module.

tobias’s picture

tobias commented

Hi Kyle,

Thanks for this work. I have now installed the dev version and applied the patch, which appears to be working on my install. When I look at the subscriptions page for another user on the site, I get their subscriptions and not my own. When I change their subsription settings it changes their settings, not my own.

Cheers,

Tobias

kyle_mathews’s picture

kyle_mathews commented
Status: Needs review » Fixed

Great! Marking this fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.