Convert and encourage content-type plugins to return renderable array [#1227952]

This is a first stab, at converting plugins to return a renderable array; and also in case they return plain HTML in the $block->content, at least convert it to '#markup' => $block->content;.

The patch isn't full, but marking as needs review, to get feedback.

Comment	File	Size	Author
#2	1227952-ctools-render-array-2.patch	1.47 KB	amitaibu
	ctools-renderable-array.patch	2.03 KB	amitaibu

Comments

Comment #1

merlinofchaos commented 28 July 2011 at 22:47

Status:

Needs review

» Needs work

There's no need to use #markup if we're just returning strings. The system can handle that and I think we should just stay with it. Using #markup is adding weight to the system that simply doesn't need it.


   $block->title = check_plain($account->name);
+
+  $element['user_picture'] = array(
+    '#theme' => 'user_picture',
+    '#signature' => $account,
+  );
+
+
   $block->content = theme('user_picture', array('account' => $account));

That doesn't do anything. :)