validation errors / xhtml broken [#1228122]

Hey people! Awesome project, but i do have some issues, coding standards is one of them.

Using the w3c validator ( http://validator.w3.org/ ) to check my markup, i found the media modules does suffer from some coding standard issues.

This would be no problem when we replace 'embed' with 'object', from what i've read, but i am not a flash guru, so possibly other fixes may be better.

"Error Line 196, Column 172: there is no attribute "src"
…ode" value="transparent" />

"Error Line 196, Column 216: there is no attribute "type"
…//www.youtube.com/v/U0X1Acrty6E" type="application/x-shockwave-flash" width="4…"

"Error Line 196, Column 254: there is no attribute "width"
…"application/x-shockwave-flash" width="480" height="360" allowfullscreen="true…"

"Error Line 196, Column 267: there is no attribute "height"
…x-shockwave-flash" width="480" height="360" allowfullscreen="true">

"Error Line 196, Column 289: there is no attribute "allowfullscreen"
…th="480" height="360" allowfullscreen="true">

etc etc etc

More info:
http://www.alistapart.com/articles/flashsatay

Running current latest beta's for all packages (the most up-to-date versions), all versions suffer from this issue.

Apologies if this a duplicate, but looking for validation errors in the issue queue didn't showed up anything, so here it goes.

Comment	File	Size	Author
#11	w3c_html5_validation.patch	1.1 KB	rreiss
#1	1228122-validation-errors-xhtml-broken.patch	1.49 KB	rob c

Comments

Comment #1

rob c commented 4 May 2012 at 23:31

Status:

Active

» Needs review

Status	File	Size
new	1228122-validation-errors-xhtml-broken.patch	1.49 KB

This is just a first attempt to see if these validation issues can be fixed.

Hope i got it right, still in doubt if this works on all browsers we try to target / hope i didn't miss that one thread explaining why we use the current double embed way.

I know this patch works for Firefox 12 on Ubuntu/Windows 7, IE8 on Windows 7, Chromium 18 on Ubuntu and all defined variables are used. If i set the fullscreen option for example to disable (and empty cache) it no longer displays the fullscreen button on the player in IE8 and Firefox 12, so it looks like that's still working, but please confirm.

Comment #2

lucascaro commented 5 May 2012 at 00:28

Status:

Needs review

» Reviewed & tested by the community

confirmed that it's working in IE 5 to 10!
also firefox 3.6+

Comment #3

jamieshek commented 8 May 2012 at 15:59

I'm new to patches. Can you point to some resources that while help me apply this patch?

I'm also in need of you tube video content that validates.

Thanks,
Jamie

Comment #4

rob c commented 8 May 2012 at 16:59

jamieshek, you can read more about applying patches here: http://drupal.org/patch/apply

Comment #5

lucascaro commented 8 May 2012 at 17:00

you can basically go to the module's directory, download the patch and then do a patch -p1 < 1228122-validation-errors-xhtml-broken.patch

Comment #6

RobW commented 24 August 2012 at 18:18

Nice work. Committed in http://drupalcode.org/project/media_youtube.git/commit/a22cd36.

To get really nice output in 7.x-1.x we need to backport the changes made in #1555276: Clean up theming function, Use recommended iframe player by default, without js. If anyone wants to put work in there, it would be greatly appreciated.

Comment #7

RobW commented 24 August 2012 at 18:22

Status:

Reviewed & tested by the community

» Fixed

Comment #8

rob c commented 25 August 2012 at 16:29

Thanks!
#1555276 I'll have a look at it RobW. (do have a busy schedule, but when time permits ;) )

Comment #9

RobW commented 25 August 2012 at 18:41

Awesome. The big benefit of the patch from a validation/ OCD html author standpoint is that it puts all of the html output in an editable tpl. I have about a year's worth of work before backporting it bubbles to the top of my list, so the only way it's going to get into 1.x is with help from friends. If you do decide to work on it and have questions, let me know.

Comment #10

8 September 2012 at 18:51

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #11

rreiss commented 3 October 2013 at 13:06

Version:	7.x-1.x-dev	» 7.x-2.0-rc3
Status:	Closed (fixed)	» Needs review

Status	File	Size
new	w3c_html5_validation.patch	1.1 KB

Hi,

The following error appears on the Markup Validation Service:

The frameborder attribute on the iframe element is obsolete. Use CSS instead.

According to w3scools

The frameborder attribute is not supported in HTML5. Use CSS instead.

Therefore I'm attaching a patch to be reviewed and commited. The patch is using the seamless attribute and CSS as a fallback for IE & FireFox. Thanks, Rotem

Comment #12

rob c commented 3 October 2013 at 18:04

Status:

Needs review

» Closed (fixed)

I know it's close to the same issue, but please open up a new issue for your patch Rotem. We try to leave closed issues closed, especially if the patch does not affect the same code.