Patch attached

CommentFileSizeAuthor
#4 1229052.patch1.22 KBericduran
#3 0001-Issue-1229052-by-ericduran-Fixed-GigyaUser-logout-fa.patch1005 bytesericduran
#2 0001-Issue-1229052-GigyaUser-logout-failed.patch973 bytesericduran
0001-Fixing-Undefined-index-destination-in.patch988 bytesericduran

Comments

q0rban’s picture

q0rban commented
Status: Active » Needs review

Looks good, although I'm not crazy about inline ternaries and the fact that destination still exists even though it's not being used. This might be easier to read:

$_GET['destination'] = empty($_GET['destination']) ? 'socialize-logout' : 'socialize-logout?destination=' . urlencode($_GET['destination']);
ericduran’s picture

ericduran commented
StatusFileSize
new 0001-Issue-1229052-GigyaUser-logout-failed.patch973 bytes

Here's a better patch.

I also got rid of the global $user object because it wasn't being used. It also doesn't append an empty destination query string when its empty.

ericduran’s picture

ericduran commented
StatusFileSize
new 0001-Issue-1229052-by-ericduran-Fixed-GigyaUser-logout-fa.patch1005 bytes

Here's another patch same issue, This time is its gigya.pages.inc

ericduran’s picture

ericduran commented
Version: 7.x-3.0-beta2 » 7.x-1.x-dev
Priority: Normal » Major
StatusFileSize
new 1229052.patch1.22 KB

Here's another patch. Rolled against 7.x-1.x-dev

This is a fixed for both the .module and the .pages.inc files.

I'm bumping the priority up on the issue :) Hope thats ok. This patch is necessary when running SimpleTest. If not the index causes the test to fails.

q0rban’s picture

q0rban commented
Status: Needs review » Reviewed & tested by the community

Looks great. We're currently using this patch with success.

gambaweb’s picture

gambaweb commented
Status: Reviewed & tested by the community » Closed (fixed)