Delete triggered actions [#1229112]

Triggered actions should be deleted automatically after a certain period of time.

function scheduled_actions_cron() {
 ...
  $max = REQUEST_TIME - variable_get('scheduled_actions_archive_day_limit', 1) * 86400; //24*60*60
  db_delete('scheduled_actions')
    ->condition('triggered', 0, '>')
    ->condition('triggered', $max, '<=')
    ->execute();

Comment	File	Size	Author
#5	1229112_scheduled_actions_delete_archive_5.patch	8.91 KB	paranojik
#3	1229112_scheduled_actions_delete_archive.patch	2.54 KB	slashrsm

Comments

Comment #1

slashrsm commented 25 July 2011 at 19:10

Status:

Active

» Needs work

That sounds like a reasonable feature. I think we should expose this also in administration page to allow user to set 'scheduled_actions_archive_day_limit' and also to enable/disable this feature. What do you think?

Comment #2

pasqualle

🇭🇺 Budapest

commented 26 July 2011 at 06:36

Yes, I agree,
zero should mean disabled..

something like

  $form['scheduled_actions_archive_day_limit'] = array(
    '#type' => 'select',
    '#title' => t('Triggered actions log'),
    '#default_value' => variable_get('scheduled_actions_archive_day_limit', 1),
    '#options' => array(
      0 => t('Do not delete'),
      1 => t('Delete after 1 day'),
      7 => t('Delete after 1 week'),
      30 => t('Delete after 30 days'),
    )
    '#description' => t('The maximum days to keep triggered actions archived. Requires a <a href="@cron">cron maintenance task</a>.', array('@cron' => url('admin/reports/status')))
  );

and at cron check for zero first..