i downloaded your master branch and i got:
Fatal error: Call to a member function title() on a non-object in mpc.module on line 430
also my version of mpc does not have the "-f" option ..

CommentFileSizeAuthor
#1 mpc.module.patch370 bytesfoxfabi

Comments

foxfabi’s picture

foxfabi commented
Status: Active » Needs review
StatusFileSize
new mpc.module.patch370 bytes

i fixed the issue with the attached patch.
testing the module i think the ls/% callbacks are not working like expected..
next, previous, shuffle works fine.

making the output available for blocks would be a great improvement.
also should you put the MPC:: classes outside the module code

i used ampache, zina and many others. a year ago i switched to a similar solution but without a module ;)

for mobile devices you can use mobile_tools and theme such as garland_mobile

thank you for the work.

alex.a’s picture

alex.a commented
Assigned: Unassigned » alex.a
Status: Needs review » Fixed

Thanks for the patch. I updated mpc.module as you suggested and tagged it with the tag "6.x-0.6".
I'm glad your mpc has --format. I wonder why title() didn't work. Which version of php do you have? Is it not a good idea to have a property and a method with the same name?

Did you run the mpc/db page? I think it is required in order for ls to work properly. It should probably be in an admin page or people wouldn't know that it exists. I use ls and search all the time in order to browse my music and construct the current playlist. I use them from the links. I never type the url by hand.

I will log the mpc box suggestion as a separate issue and also do some code refactoring to move the classes outside of mpc.module, as you suggest. I think Drupal 7 has better support for classes (it loads them automatically). I will also reformat the code so that it complies with drupal code conventions so that I can apply for full project status (now that I have users:).

I converted all my stand-alone php applications to Drupal modules and I installed them in my personal Drupal database. I couldn't get ampache to work with mpd. I've thought of using mpc with mobile devices but since I don't have one yet, I haven't pursued it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.