Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
markup
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Jul 2011 at 01:47 UTC
Updated:
29 Jul 2014 at 19:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jessebeach commentedDerp, forgot to change comment.tpl.php to comment-wrapper.tpl.php.
Comment #2
jessebeach commentedadded html5 tag
Comment #3
jacinetagging!
Comment #7
Jeff Burnz commentedsection seems to make sense, nodes and comments as articles, with section as the wrapper,
Comment #8
lars toomre commentedThere is another double >> in the line:
Rereading carefully, skip the above... But now am wondering if print $attributes includes a space before first attribute if $attributes is not empty.
Comment #9
Jeff Burnz commentedOnly thing actually changed is the element (swapped div for section), everything else is the same.
Comment #10
Anonymous (not verified) commentedTested and this works (when using Seven theme).
It makes sense to use section for this, it is an area of content that has a heading but that doesn't make sense as an article.
RTBC
Comment #11
jacineSweet! Nice work guys ;)
This is still RTBC, just updating the sprint tag to keep track of it while we wait.
Comment #12
dries commentedCommitted to 8.x. Thanks.
Comment #13
Jeff Burnz commentedAssuming fixed? Hooray, my first patch for Drupal 8 - very chuffed :)
Comment #14
jacineSweet! Congrats Jeff :D
Comment #15
jessebeach commentedcongrats Jeff!
Comment #17
cosmicdreams commentedI see that the comment section still has an "id='comment'" attribute. Did we want to eliminate the use of ids in our markup or am I remembering that wrong.
Comment #18
Jeff Burnz commentedRemoving ID's is a totally separate issue, I dont know if there is an open issue for this.
Comment #19
jacineNothing else needs to be done here. #comments ID is a useful anchor that we shouldn't remove IMO.
Comment #20
jacineCleaning up tags/component.
Comment #20.0
jacineadded cross link to comment.tpl.php conversion issue