The access plugin doesn't seem to work for me. The settings form was empty, and items had not been added. Simple patch to follow.

Comments

steven jones’s picture

Status: Active » Needs review
StatusFileSize
new2.22 KB
new2.23 KB

Patch attached, needed to return the form from the form builder.

laroccadahouse’s picture

these are the errors i'm getting:

Warning: in_array() expects parameter 2 to be array, null given in mobile_tools_is_mobile_ctools_access_check() (line 68 of .../sites/all/modules/mobile_tools/plugins/access/is_mobile.inc).
Warning: in_array() expects parameter 2 to be array, null given in mobile_tools_is_mobile_ctools_access_check() (line 69 of .../sites/all/modules/mobile_tools/plugins/access/is_mobile.inc).
Warning: in_array() expects parameter 2 to be array, null given in mobile_tools_is_mobile_ctools_access_check() (line 68 of .../sites/all/modules/mobile_tools/plugins/access/is_mobile.inc).
Warning: in_array() expects parameter 2 to be array, null given in mobile_tools_is_mobile_ctools_access_check() (line 69 of .../sites/all/modules/mobile_tools/plugins/access/is_mobile.inc).

I applied your patch but i'm still getting the error...

laroccadahouse’s picture

UPDATE:
It seems this patch is useful as without it I could not go into my variants and adjust the mobile device types after removing the patch.. After REapplying the patch, I can edit the mobile device types again.

-------

these errors were to due to user error. I had not completely set up the selection rules for each variant of my homepage panel to account for desktop or mobile device. I reverted the is_mobile.inc file back to the original version after setting those rules correctly and now I have no errors.

steven jones’s picture

Could you just post new comments instead of editing please?

Does the patch work for you or not?

laroccadahouse’s picture

When I fixed my own user error i no longer got the warnings, but I could not edit the selection rules. I don't know if this is a consequence of adding and removing the patch or if their was an issue with the module to begin with.

At this point i have the patch applied and I can use the module with no issues.

travisc’s picture

Yep this patch works. Mobile tools panel selection rules are broken without it.

travisc’s picture

edit:

actually it works, i'm using panels everywhere, be sure to select a template for the varient as well as the panel layout.

minoroffense’s picture

Status: Needs review » Reviewed & tested by the community
minoroffense’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Committed

Anonymous’s picture

Version: 7.x-2.x-dev » 7.x-2.0-unstable1
Priority: Normal » Critical
Status: Closed (fixed) » Active

Patch doesn't work for 7.x-2.0-unstable1. This completely paralyzes the development of my whole site. Could someone please make a patch for this version?

devin carlson’s picture

Status: Active » Closed (won't fix)

The 7.x-2.x branch of Mobile Tools in now unsupported.