_viewfield_get_view_args() needs to go.

Comments

sun’s picture

Priority: Normal » Major

Also, vname should be split into 'view' and 'display'. The combined '$view|$display' string value is hard to maintain.

keithm’s picture

Status: Active » Needs review

Regarding vargs, if we store a serialized array of arguments produced by parsing the arguments using the current input method (single text field; comma-delimited list with quotation exceptions), we need to re-quote the exceptions at edit time.

Example vargs and parsed array using parsing code from _viewfield_get_view_args():

$vargs = '[node:nid],foo,"foo, bar","foo, ""bar"", bax"'
$parsed = array('[node:nid]', 'foo', 'foo, bar', 'foo, "bar", bax');

Alternatively, we could implement a multiple value input method for arguments, and avoid the whole quotation exercise, at a significantly higher UI implementation cost.

Thoughts?

jerdavis’s picture

Version: 7.x-2.x-dev » 8.x-3.x-dev
Category: Task » Feature request
Issue summary: View changes
Status: Needs review » Active

I'm going to move this to Drupal 8 as a feature request. At this time I don't see the value in altering how arguments are stored in D7 but would be on board for some UX improvements in 8.