Hi.
For me the accordion renderer isn't working.

Let me explain my configuration:
1. Created Quicktab Block, 2 Tabs, one consists of an exposed form for View 1, the other contains View 1 Page 1.
2. Placed the Block in a region, displaying only on certain path /path1
3. Set renderer to 'accordion'.
4. Both blocks are rendered on top of each other, no accordion behavior is noticeable.
5. I can switch the renderer, then everything works okay for me.
6. No JS errors on page (checked via Firebug)

But it seems to me, there is a javascript path in ./plugins/QuickAccordion.inc on Line 55 where there is no corresponding javscript with the path .../js/qt_accordion.js.

Can someone please help me?

Comments

katbailey’s picture

katbailey commented
Status: Active » Fixed

Yikes, I had moved the js for the accordion into a separate file but forgot to commit the file :-(
Fixed with this commit http://drupalcode.org/project/quicktabs.git/commitdiff/302844c062b9cf43c...
You'll need to either wait until the new -dev version is built or pull directly from git. But I will probably create a new beta just for this.

-osiris-’s picture

-osiris- commented
Status: Fixed » Active

It still doesn't work.
I downloaded the js from your commit, and placed it inside the corresponding directory, then refreshed the cache.
The file now gets loaded, and the behaviour inside is attached, I can see this in them DOM Viewer of firefox.
Alas, my blocks are not rendered as quicktabs, they stay on top of each other, without any javascript behavior.

Am I missing something?

katbailey’s picture

katbailey commented

Oh gawd, yep, there's a problem - I can't believe I didn't catch this when testing, it's because I was always loading the regular quicktabs.js as well as the qt_accordion.js and the latter doesn't work without the former. I will try to have this fixed by end of day today.

katbailey’s picture

katbailey commented

OK, can you try it now, I just committed a fix (hopefully once and for all :-/)

vm’s picture

vm commented
Status: Active » Fixed

I ran into this issue as well. I can confirm that the accordion is now working as it once was.

smerth’s picture

smerth commented

Hi Kat, Just downloaded Quicktabs and got the regular tab blocks running but accordion blocks are not working... I read the thread and I am assuming the 3.0-beta2 on D.O includes the fix you mention above... if so it doesn't appear to be working... if not, sorry for jumping the gun,... I'll wait for you to roll a new version... Cheers ;-)

katbailey’s picture

katbailey commented

@smerth, no it was the beta2 version that introduced this bug. I have now made a new beta3 release which has the fix.

smerth’s picture

smerth commented

Hi Kat, thanks for the quick reply. Looks like there is an issue with accordion in 3.0-beta2. But.... its a beta!! ;-)

katbailey’s picture

katbailey commented
Version: 7.x-3.0-beta2 » 7.x-3.x-dev

Um, not sure I understand @smerth. As I said before, the 3.0-beta2 version has this bug but it has been resolved in the beta3 version - there's nothing I can do about beta2. Have you upgraded to beta3?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.