D7 port

This is just the state of paranojik's work made in his sandbox as patch.

#1 worked for me so far, could we have this as an dev release?

#1 (paranojik's sandbox code from http://drupal.org/sandbox/paranojik/1232184) has also worked great for me.

In fact it works well enough that we are using it as a dependency for the OpenID ICAM Extension. That module needs to publish an OpenID return to URL in a simple XRDS document to pass enhanced RP Discovery.

The OpenID Server module does this using XRDS Simple in Drupal 6, and so does our module. Paranoijik's port appears to work fine in Drupal 7 for this purpose at least. We need to either get a 7.x version of this going instead of that sandbox, or declare the module officially dead and then I'll duplicate that code into OpenID_icam. However I think that's the wrong move since other modules might come along in the future who want a simple XRDS document. XRDS Simple provides that functionality and has got a lot of use/testing as a dependency of the OpenID server module in 6.x.

@walkah, so could we see a at least a 7.x-1.x-dev branch started with this initial port please? Or could Barrett (my co-maintainer on OpenID ICAM) and I co-maintain and take over 7.x +?

Thanks for your consideration, and +1 to the port as mostly working (other than those warnings and the comment cleanup anyway). If you're agreeable I can do some cleanup and check into those warnings get it a bit further along than it is to start with.

It seems like walkah has taken a hiatus from a number of his projects...

@markwk, actually I made contact last week via a relayed message via a conference call he was on. He said that he will look into getting a D7 port alive for us. So, hopefully it won't be too much longer, and meanwhile the paranojoik code is usable as-is. Or if not, we could track improvements to it on this issue.

@damien_vancouver: Great to hear that. Not really a code issue, more a maintenance situation. Like to keep the chatter to a single place.

The lack of a D7 port for XRDS Simple is now becoming critical for the OpenID ICAM module. The GSA wants to be able to distribute our OpenID_ICAM module, for use on some very high profile US gov sites, but we are unable to as long as our XRDS Simple dependency remains a sandbox project.

@walkah, I beileve you discussed this with OMP on a coference call Jan 5th, At that time you said you would get the port ready "soon". It appears we now need it ASAP. From an email to me this morning from the IDManagement.gov folks:

Hi Damien - Can you get the updated drupal 7 XRDS module posted to drupal.org? We need a way to distribute the module and GSA doesn't want us to use a lab resource.

I've exlplained that I cannot do this on my own, and require help from the module maintainer...

If you're low on time, I'd like to suggest again that Barrett and I (co-maintainers of openid_icam) be allowed to co-maintain the Drupal 7 port of XRDS_Simple. No one else is using it, our module depends on it, so I think we have more claim to it than anyone else (or you if you are going to leave it unported).

Otherwise, could I please get an estimate of how much longer we will have to wait so I can advise the GSA folks of a realistic schedule?

Thank you.

:(

I just tested the sandbox project as well and it seems to be working fine... Would love to see this sandbox project committed as a 7.x-1.x branch of xrds_simple...

The sandbox does seem to work great, however there is at least one minor task that needs doing:

The code is full of @todos left by the Coder module when the port was created. e.g.:

/**
 * @todo Please document this function.
 * @see drupal.org/node/1354
 */
function xrds_simple_init() {

needs to be:

/**
 * Implements hook_init().
 */
function xrds_simple_init() {

and so on.

The module also needs a README.txt, explaining it's an API module with no UI, and with instructions on using it publish an XRDS document: You have to implement hook_xrds() from your own module and set an array with the correctly named parameters to get it to do something, otherwise the XRDS is not shown.

Still no response from the module maintainer. I'm out of time, and I'm stating publically here that this module is efectively abandoned, and that I am requesting co-maintanership as a result.

My project to get OpenID logins on US gov websites via OpenID ICAM is now seriously in danger of being de-railed from the XRDS Simple dependency not being available. Two months of asking from every possible angle has resulted in no movement at all on this port (which let's be honest, is about 2 hours of work. I've spent 5 times that already just trying to make it happen politically). This is ridiculous.

The GSA no longer wants to wait and wants ne to re-create the functionality or "make a new module". This violates Drupal's duplication policy. Thus I am between a rock and a hard place. I need the port, or co-maintainer access, immediately.

I heard back from the maintainer this morning, I guess he hasn't seen any of the issue queue posts. We will hopefully have movement in the next few days.

I've started a new sandbox for the port here: http://drupal.org/sandbox/damienvancouver/1418982

So far, I've fixed all coder warnings and commented all the functions.

I/we should fix and test #1120614: Notices from xrds_simple_document() and create a README.txt.

After the above, I think the code's ready to go. We can backport the fix for #1120614 to 6.x but it warrants much careful testing there, given that openid_provider is using XRDS Simple.

If anyone else has any additions for the D7 port though, please post patches against the sandbox above and I'll review and commit them. Thanks!

Sorry for the spam. Setting issue status to "Needs work"

EDIT, Jan 27th: I've got maintainer permissions now, so I'll be getting the latest code into a 7.x-1.x branch and a 7.x-1.0 release done by early next week.

Done and done - a 7.x-1.0 release should appear shortly. Please open new issues against 7.x-1.x-dev for any new issues that are encountered!

Awesome work ! Many thanks !