Attached a patch, please review it.

CommentFileSizeAuthor
#14 privatemsgAutocompleteContains.patch3.94 KBPatrizio
#11 aquaknow_realname-1232374-10.patch2.13 KBpaolomainardi
#10 aquaknow_realname-1232374-10.patch2.13 KBpaolomainardi
#8 aquaknow_realname-1232374-8.patch1.62 KBpaolomainardi
#7 aquaknow_realname.install-1232374-16.patch508 bytespaolomainardi
#6 aquaknow_realname-1232374-16.patch1.26 KBpaolomainardi
#1 privatemsg_realname_fulltext_search.patch1.76 KBpaolomainardi
privatemsg_realname_fulltext_search.patch1.3 KBpaolomainardi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
FileSize
privatemsg_realname_fulltext_search.patch1.76 KB

In the attachment the correct one, to get rid of % escaping problems.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review

Remember to set issues to needs review when posting patches.

Status: Needs review » Needs work

The last submitted patch, privatemsg_realname_fulltext_search.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Category: bug » feature

Also, we need a better title for the settings option (what you have is *way* too technical) and it needs to be variable_del()'d in the uninstall hook.

Regarding the title, maybe something along the lines of "Search anywhere in the real name for autocomplete suggestions" or something along those lines. And a description would be nice too, maybe explaining it in reverse: "If unchecked, only suggestions which start with the search text will be displayed." or something like that.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

Berdir,

I have forgotten to write that this patch was meant to be reviewed as an idea to be applied if really needed.

Thanks for your feedback, is exactly what i need.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
Status: Needs work » Needs review
FileSize
aquaknow_realname-1232374-16.patch1.26 KB

Patch in the attachment.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
FileSize
aquaknow_realname.install-1232374-16.patch508 bytes

The uninstall function implemented.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
FileSize
aquaknow_realname-1232374-8.patch1.62 KB

In the attachment the final one, to be used in alternative of #6.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Needs work

Please provide a single patch with all changes. Also, you still need to update the #title as explained in #4.

Also, I think what you're doing right now is incorrect, you need to use *either* one of the search replacements, not both. Right now, you're just adding an additional one.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
FileSize
aquaknow_realname-1232374-10.patch2.13 KB

Attached a patch with all changes in it, please point me better what do you mean with to use "either" and not both replacement, probably i don't understand at all the private query system.

Thanks.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
Status: Needs work » Needs review
FileSize
aquaknow_realname-1232374-10.patch2.13 KB

Changed in needs review.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

Up

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

Sorry, up.

Patrizio’s picture

Patrizio CreditAttribution: Patrizio commented
FileSize
privatemsgAutocompleteContains.patch3.94 KB

My solution extend this feature to all type of autocomplete in privatemsg (username, realname, role)

Status: Needs review » Needs work

The last submitted patch, privatemsgAutocompleteContains.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented 
===================================================================
--- privatemsg.admin.inc	(revision 3723)

--- privatemsg.admin.inc	(revision 3723)
+++ privatemsg.admin.inc	(working copy)

You need to create the patch with -p1 to have it accepted by the testbot. The easiest way to do that is using git.

+++ privatemsg_roles/privatemsg_roles.module	(working copy)
@@ -177,7 +177,12 @@
+  else {
+    $fragments['query_args']['where'][] = '%%' . $search .'%%';

Trailing spaces.

oadaeh’s picture

oadaeh CreditAttribution: oadaeh as a volunteer commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

This issue is being closed because it is against a branch for a version of Drupal that is no longer supported.
If you feel that this issue is still valid, feel free to re-open and update it (and any possible patch) to work with the 7.x-1.x branch (bug fixes only) or the 7.x-2.x branch.
Thank you.