memcache-lock.inc should include dmemcache.inc (using require_once) just like memcache.inc and memcache-session.inc do.

I got a fatal error about dmemcache_get() being undefined while running install.php ($conf['lock_inc'] was already defined in my settings.php).

CommentFileSizeAuthor
#4 1233634-memcache-require-once.patch1.26 KBneclimdul
#1 memcache-require-once-1.patch1.16 KBc960657

Comments

c960657’s picture

c960657 commented
Status: Active » Needs review
StatusFileSize
new memcache-require-once-1.patch1.16 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

neclimdul’s picture

neclimdul
He/Him
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)
StatusFileSize
new 1233634-memcache-require-once.patch1.26 KB

Should be backported to d6(at least memcache-lock.inc doesn't have this which just bit me).

The results of cherry-picking catch's commit attaches as a format-patch. There was one conflict of the require_once already existing.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Patch (to be ported) » Needs review

Guess really this is NR

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.