I can't figure out a way to prevent the Ad nodes from being published automatically, I went in to the Content Types area via Admin (/admin/content/types) and removed the check from the Default options 'Publish' checkbox, but the node ignores this and once a node is submitted, it's automatically published.

I've installed this a couple times and have had the same problem. The only way to stop the publish is to create the node, then go back in, and uncheck the Publish.

CommentFileSizeAuthor
#13 unpublish_checkbox-123396-13.patch1.17 KBSt4t0
#9 unpublish_checkbox-123396-1.patch22.51 KBfgm

Comments

mcurry’s picture

mcurry commented
Assigned: Unassigned » mcurry
Status: Active » Fixed

Definitely a bug I introduced in 1.5. You can use an older version or wait for the next release build (1.5.1)

mcurry’s picture

mcurry commented

Drupal-5-1.5.1 release is here:

http://drupal.org/node/123403

Should fix the problem.

bsuttis’s picture

bsuttis commented
Title: Unchecking 'Publish' checbkox doesn't prevent nodes from being published » Unchecking 'Publish' checkbox doesn't prevent nodes from being published

Great, this fixes it. Thanks!

mcurry’s picture

mcurry commented

Thanks for the quick report. Sorry for the trouble.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
eric66’s picture

eric66 commented
Version: 5.x-1.5 » 6.x-2.0-alpha6
Status: Closed (fixed) » Needs review

I have exactly the same problem with version 6.x.2.0-alpha6, any sugestions on how to patch/fix it? Thanks in advance!

mcurry’s picture

mcurry commented
Assigned: mcurry » Unassigned
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Active

This is currently still true on 6.* and being worked on. Publishing rules were a bit approximative and we have been formalizing them recently.

Essentially, when the patch lands:
- on creation, if the author is not an admin forcing publishing manually, default node creation options will be applied
- on update, if the author resets the date in 'reset' or 'force" mode, node will be republished, unless author is an admin and sets the unpublished status manually on the "Publishing options" fieldset
- when saving, either from the UI or in code, any node with an expiration date set in the past will always be unpublished

Note: similar issue on #123416: When renewing ad, re-publish if it's expired and workflow is set to publish automatically.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review
StatusFileSize
new unpublish_checkbox-123396-1.patch22.51 KB

Status: Needs review » Needs work

The last submitted patch, unpublish_checkbox-123396-1.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review

#9: unpublish_checkbox-123396-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, unpublish_checkbox-123396-1.patch, failed testing.

St4t0’s picture

St4t0 commented
Version: 6.x-2.0-alpha6 » 6.x-3.x-dev
Component: Miscellaneous » Code
Status: Needs work » Needs review
StatusFileSize
new unpublish_checkbox-123396-13.patch1.17 KB

Bug confirmed.
Patch fixes this in the latest 6.x-3.x

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

All tests pass: committed to 6.x-3.x.

Needs to be ported to 7.x-3.x.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Patch (to be ported) » Fixed

Propagated to 7.x too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.