Closed (fixed)
Project:
Drupal core
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
31 Oct 2004 at 12:26 UTC
Updated:
29 Nov 2004 at 12:15 UTC
Jump to comment: Most recent file
If the throttle.module isn't enabled, the 'Throttle' table header and the Throttle checkboxes shouldn't be displayed. Within drupal, we never do this so - in sake of consistency and usability - this patch only displayes the 'throttle'-related fields when the module is enabled.
I also updated the helptext to be certain people know what todo to enable the throttle functionality. (Though maybe this helptext should be inside the throttle.module?)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | system-block--throttle_0.patch | 6.78 KB | Stefan Nagtegaal |
| #2 | system-block--throttle.patch | 6.53 KB | Stefan Nagtegaal |
| #1 | system-throttle.patch | 4.23 KB | Stefan Nagtegaal |
| block-throttle.patch | 3.67 KB | Stefan Nagtegaal |
Comments
Comment #1
Stefan Nagtegaal commentedAnd the second patch for
system.module.Pease review, comment or apply... :-)
Comment #2
Stefan Nagtegaal commentedOkay, I fixed a little issue inside the block.module-patch and now unified the two patches into one..
When this patch is applied, the 'Throttle'-fields inside the blocks-overview table and the modules-overview table doesn't get displayed.. Please test, comment or apply this patch...
Comment #3
Stefan Nagtegaal commentedKeeping up with CVS and modified the patch conform drupals coding styles..
Please, review and comment or apply!
Comment #4
Stefan Nagtegaal commentedKeeping up with CVS and modified the patch conform drupals coding styles..
Please, review and comment or apply!
Comment #5
Stefan Nagtegaal commentednew patch as requested by DRies
Comment #6
dries commentedCommitted to HEAD. Thanks.
Comment #7
(not verified) commented