Event 4.5.0 doesn't correctly use input formats [#12355]

On line 351:

  $node->teaser = $output . ($node->teaser ? '<div class="content">'. check_output($node->teaser) .'</div></div>' : '</div>');
  $node->body = $output . ($node->body ? '<div class="content">'. check_output($node->body) .'</div></div>' : '</div>');

Should be:

  $node->teaser = $output . ($node->teaser ? '<div class="content">'. check_output($node->teaser, $node->format) .'</div></div>' : '</div>');
  $node->body = $output . ($node->body ? '<div class="content">'. check_output($node->body, $node->format) .'</div></div>' : '</div>');

Otherwise the event module won't use the input filters the user chose.

Patch should be included. Check it works first :)

Comment	File	Size	Author
	event_input_fix.patch	779 bytes	arevos

Comments

Comment #1

Lou Quillio commented 2 December 2004 at 21:53

This patch fixes the input filter bug, but the output ends up wrapped in

<div class="content">
  <div class="event">
    <div class="content"> 
      [output]
    </div>
  </div>
</div>

.content class is applied twice, which causes some unintended inheritance, imo. For instance, If a theme's font-size for .content is less than 1em, text is rendered very small because it's been styled twice.

Maybe this instead (should be line 361):

  $node->teaser = $output . ($node->teaser ? check_output($node->teaser, $node->format) .'</div>' : '</div>');
  $node->body = $output . ($node->body ? check_output($node->body, $node->format) .'</div>' : '</div>');

I'm assuming that the inner .content div is the extra one; could be wrong about that.

Thanks for the original patch.

Comment #2

xand commented 16 January 2005 at 16:23

I would jsut like to verify that the problem and the last solution both exist and are correct... (for the latest 4.5.2)

Comment #3

neale commented 1 August 2005 at 18:21

Yes, the second patch (removing the

) appears to work great. Please add this to the codebase, I got bit by this bug too and came up with the same patch independantly before I found this bug.