Closed (fixed)
Project:
fancyBox
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Aug 2011 at 13:52 UTC
Updated:
2 Dec 2011 at 02:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
shixish commentedGoing to 1.3.1 solved the crashing problem but it appears that the ImageCache setting has no effect on the image being displayed (it's still showing the original image).
Comment #2
pzerimars commentedJust bumped into this problem myself. Here's a patch to fix the
Property 'onStart' of object #<Object> is not a functionerror against 6.x-1.x-dev.Edit: Please note, this is for version 6.x-1.x-dev. I didn't notice this issue was for 7.x-1.x-dev. Appropriate patch for 7.x-1.x-dev may be found below.
Comment #3
Andrew Schulman commentedI also have this problem, with fancybox 1.3.4.
pzerimars, I'm confused by your patch - it doesn't apply to fancybox-7.x-1.x-dev of 2011-Feb-25. Is it supposed to patch sites/all/modules/fancybox/js/fancybox.js?
Comment #4
pzerimars commentedSorry about that. Didn't see this was for 7.x-1.x-dev.
Here's a patch for this version. It's a module patch instead of a javascript patch. It strips out the empty option values before they get added javascript.
Comment #5
Andrew Schulman commentedpzerimars, thanks. I applied your patch, and the 'onStart' error has gone away. But, now when I click on an image, all I get is a popup that says: "The requested content cannot be loaded. Please try again later." Is this part of the same problem, or a different problem? Caused by the patch?
Javascript console and Apache error log are both empty after I get this message.
Comment #6
Andrew Schulman commentedNevermind about the "requested content cannot be loaded" - it was caused by a bad jQuery selector. The module doesn't tell you anything about what should be selected, so you're more likely to get it wrong than right, but that's a separate bug.
Comment #7
bas.hr commentedFixed in #1292626: Many fixes in one big patch