The patch for taxonomy.module to prevent terms from being displayed to users who don't have permission to see the terms doesn't work with the 4.5 release. The original patch is here.

The rest of the module works fine. Without the patch, users who may not have permission to see a term's nodes will still see the term in listings, like the forum table. Because of this, they can add new nodes to terms they don't have permission to view, which is weird. But if all you want to do is make term's nodes editable by role, this patch isn't really necessary.

This module (with the patch to taxonomy.module) is a perfect solution to private forums. If this patch works, admins can setup forums only accessible by roles.

I don't believe it is necessary for the default Drupal to be patched in order to make this module available. Users who want this functionality can patch taxonomy.module themselves. The Drupal devs need to come up with a generic way to not display taxonomy terms for users who don't have permission to see them. This patch inserts a function that is specific to this module. Ideally, the Drupal devs will create a hook there so any module can insert this functionality. But for now, it's fine to have users patch there own install if they want to use this.

Comments

pyromanfo’s picture

Assigned: Unassigned » pyromanfo

Done, check CVS. I checked everything in. Also, the patch to taxonomy.module checks taxonomy_access in way more places, hopefully it isn't a performance detriment. If anybody thinks I checked taxonomy_access in a place that doesn't make sense, let me know and I'll remove it. It's only one DB call so I hope it's not that much overhead. But now in the taxonomy forms, or taxonomy page or anything else they shouldn't see taxonomies they aren't allowed to.

joshuajabbour’s picture

sweet. I'll test it out today...

Anonymous’s picture