When updating a D7 install from 7.4 to 7.7 I came across an infinite loop before the update process fully finished. An issue was created for Drupal Core while the problem was debugged.

I have since debugged the problem and found the cause to be down this module having a call to the l() function in the hook_menu() implementation, this coupled with a menu_get_item() call in custom search's hook_theme() caused the inifite loop.

The original core issue is #1232346: Easy to trigger multiple menu rebuilds per page (including infinite recursion) via menu_get_item() since 7.12 and the custom search issue is #1235878: Infinite recursion in D7

Comments

sreynen’s picture

sreynen commented
Version: 7.x-1.5 » 7.x-1.x-dev

Wow, that sounds like it must have been a pain to track down. Thanks. I think I can just remove that link from the description and put it on the linked page instead.

mattys’s picture

mattys commented

-

mattys’s picture

mattys commented
Version: 7.x-1.x-dev » 7.x-1.5

i installed both @font-your-face 7.x-1.5 and Drupal core 7.7 today, as soon as updated to @font-your-face 7.x-1.5 my website broke, so, to get back up had reupload sql back up, although phpmyadmin was hesitant to work too

i have looked at above posts, but it is not clear to me what i need to do, to either drupal core, or latest @font-your-face

can anyone please explain in a more basic terms?

sreynen’s picture

sreynen commented
Version: 7.x-1.5 » 7.x-1.x-dev
Status: Active » Fixed

There's a link in the description of one of the admin pages for @font-your-face and this causes Drupal core to get stuck in a loop during update. The immediate solution is to simply remove that link, which I just committed to the dev version and will put in a new stable release soon.

mattys’s picture

mattys commented
Version: 7.x-1.x-dev » 7.x-1.5
Status: Fixed » Active

oh, great

can you poss advise how i find this link so i can remove myself now?

sreynen’s picture

sreynen commented
Version: 7.x-1.5 » 7.x-1.x-dev
Status: Active » Fixed

You can see exactly what I changed in the code here:

http://drupalcode.org/project/fontyourface.git/blobdiff/5ae96e68022a6913...

If you simply wait an hour, you can just install the new release. Please don't change the status unless you have a good reason to believe this is not actually fixed.

mattys’s picture

mattys commented
Version: 7.x-1.x-dev » 7.x-1.5
Status: Fixed » Active

ok, ta

sreynen’s picture

sreynen commented
Version: 7.x-1.5 » 7.x-1.x-dev
Status: Active » Fixed

Seems like there's something wrong with your browser causing it to use old form values. You should probably figure that out before you annoy more project maintainers by undo their issue changes.

mattys’s picture

mattys commented
Version: 7.x-1.x-dev » 7.x-1.5
Status: Fixed » Active

i have no idea what you are on about, but hey, thanks, and, apologies

sreynen’s picture

sreynen commented
Version: 7.x-1.5 » 7.x-1.x-dev
Status: Active » Fixed

mattys, just stop leaving comments.

mattys’s picture

mattys commented

just tried latest download, i still get the same problem, breaks drupal, or maybe this isn't the version you were referring to in post 6

sreynen’s picture

sreynen commented

7.x-1.6 should fix the problem.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.