Undefined property $unpublish_on during update

Hi Crell,
Yes at first glance is does appear to be a bug and simple to fix. But what I can't understand is how it has not been found and reported before. I took a break from supporting scheduler when the options were added to enable publishing and unpublishing independently, so I will have to check back with the code, but I still can't work out how no-one (including me) has not spotted this since then.

Patch coming up soon,

Jonathan

Just checked the actual code line number, and I think you must be using 6.x-1.8 real (as of 27th Dec 2010), not the -dev version. Please can you confirm this?

Hi,
Yes, of course most time E_ALL is not enabled. I use the devel module, and yes there are many other notices which are shown for all kinds of other modules - including some big and important modules!

Here is a patch, against the dev release of 15th May. If this sorts it, then I know we will have to fix the D7 version first, but I thought given as you are using D6 you should get the patch first.

Jonathan

So this problem has always been there we just did not see the warning?

I've checked the D7 code and this is not a problem, because it uses the EMPTY function, which does
not cause an error if the property is undefined.

Here is a slightly tidier patch for D6. Tested when updating a node type which has just publishing enabled, and
on another which has just unpublishing enabled, both already having a date set. Works ok for me, no errors,
but would be good for someone else to confirm.

Retested my patch against 6.x-1.9+4 (dev 28th July 2013). Patch applies ok (with an offset due to other changes).

notice: Undefined property: stdClass::$unpublish_on in scheduler_nodeapi()
(line 648 of /Library/WebServer/Documents/drupal6/sites/all/modules/scheduler/scheduler.module)

and

notice: Undefined property: stdClass::$publish_on in scheduler_nodeapi()
(line 656 of /Library/WebServer/Documents/drupal6/sites/all/modules/scheduler/scheduler.module)

Both of these are fixed by the patch. Can someone else verify, then mark it RTBC.

Jonathan

I just checked if this bug also occurs on 7.x and higher but it does not. hook_nodeapi() has been replaced with hook_node_update() and the rewritten code uses !empty() which does not throw this notice.

Yes, see my comment in #7 Drupal7 is fine, this fix is only required for D6.
I will re-roll the patch in a/ b/ format then re-submit for testing.

Here is the same code changes as in the patch in #7 but in a/ b/ format against the latest D6 dev

Makes sense, committed: ad6bfba.

Thanks!