I added my own custom icons to the images folder, and had to remove the width/height attributes in the img tag on line 153 of weather.module. I think this should be standard so changing icons is easier, as well as having the ability for variably sized icons. I also added the title attribute for mouseovers.

- $content .= '" alt="'.$image['alt_text'].'" width="64" height="64" />

';

+ $content .= '" alt="'.$image['alt_text'].'" title="'._weather_format_condition($metar).'" />

';

I would have submitted a patch, but I'm new, sorry.

Comments

toddy’s picture

Assigned: Unassigned » toddy

Hi,

unfortunately, you cannot remove the width and height attributes, as this will render the HTML invalid. I'll change the code to dynamically determine those values, however.

I like the addition of the title attribute, I'll include that.

Regards,
Tobias

toddy’s picture

Version: 5.x-1.1 » 6.x-5.x-dev
Status: Active » Fixed

Fixed in CVS HEAD

HXn’s picture

Good point on the validation. Thanks for the quick response.

Anonymous’s picture

Status: Fixed » Closed (fixed)
toddy’s picture

Version: 6.x-5.x-dev » 5.x-2.0

Version 5.x-2.0 has just been released.