Closed (fixed)
Project:
Weather
Version:
5.x-2.0
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
28 Feb 2007 at 21:30 UTC
Updated:
22 Mar 2007 at 11:58 UTC
I added my own custom icons to the images folder, and had to remove the width/height attributes in the img tag on line 153 of weather.module. I think this should be standard so changing icons is easier, as well as having the ability for variably sized icons. I also added the title attribute for mouseovers.
- $content .= '" alt="'.$image['alt_text'].'" width="64" height="64" />
';
+ $content .= '" alt="'.$image['alt_text'].'" title="'._weather_format_condition($metar).'" />
';
I would have submitted a patch, but I'm new, sorry.
Comments
Comment #1
toddy commentedHi,
unfortunately, you cannot remove the width and height attributes, as this will render the HTML invalid. I'll change the code to dynamically determine those values, however.
I like the addition of the title attribute, I'll include that.
Regards,
Tobias
Comment #2
toddy commentedFixed in CVS HEAD
Comment #3
HXn commentedGood point on the validation. Thanks for the quick response.
Comment #4
(not verified) commentedComment #5
toddy commentedVersion 5.x-2.0 has just been released.