// Only add submit handler once.
      eval('$element =& $form'. $form_settings['submit_handler_attach_to'] .';');

Huh?

CommentFileSizeAuthor
#2 skinr_no_eval_1236200.patch1.74 KBchx

Comments

moonray’s picture

moonray commented
Status: Active » Patch (to be ported)

Hrm... we'd actually fixed this in D6-2.x, but I guess we need to back-port it.

Here's the commit that includes the replacement for this: http://drupalcode.org/project/skinr.git/commitdiff/518b7d19561107d59e274...

chx’s picture

chx commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new skinr_no_eval_1236200.patch1.74 KB
moonray’s picture

moonray commented
Status: Needs review » Needs work

This patch isn't quite complete. It should include the parts from the commit in #1 that are:

modules/views.skinr.inc

-    'submit_handler_attach_to' => "['buttons']['submit']['#submit']",
+    'submit_handler_attach_to' => array('buttons', 'submit', '#submit'),

and skinr.module

-        'submit_handler_attach_to' => "['#submit']",
+        'submit_handler_attach_to' => array('#submit'),
moonray’s picture

moonray commented
Issue summary: View changes
Status: Needs work » Fixed

Tweaked and committed.

  • Commit c591c39 on 6.x-1.x by moonray: 
    Issue #1236200 by chx: Removed eval from skinr_form_alter.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.