I get the following message after opening or saving the 'Arrange fields - Form' page.

* Strict warning: Only variables should be passed by reference in arrange_fields_display_form() (line 569 of C:\wamp\www\contracts2\sites\all\modules\arrange_fields\arrange_fields.module).
* Strict warning: Only variables should be passed by reference in arrange_fields_display_form() (line 585 of C:\wamp\www\contracts2\sites\all\modules\arrange_fields\arrange_fields.module).

Comments

richardp’s picture

Status: Active » Closed (works as designed)

Thanks for the heads up, but unfortunately I don't think there is much I can do about that. Those strict warnings are generated by PHP when I am invoking built-in Drupal functions like so:

  $rtn .= drupal_render(drupal_get_form("arrange_fields_position_form", $form_id, $form_type));

As such, I don't think there's anything I can do to change it.

If everything else is working for you, I'd suggest just lowering your site's error_reporting() level to exclude strict warnings. They are really only helpful for programmers (for catching typos and the like), and they do not affect the normal functioning of your site. So for a production site, it's best to only show errors. Notices and Strict warnings usually just get in the way.

Thanks again,
Richard

chalee’s picture

@richardp: Thanks for the advice.

chi’s picture

Status: Closed (works as designed) » Needs work
Issue tags: +PHP 5.3 compatibility

@richardp: drupal_render() expect their parameters to be passed by reference.

- $rtn .= drupal_render(drupal_get_form("arrange_fields_position_form", $form_id, $form_type));
+ $arrange_fields_position_form = drupal_get_form("arrange_fields_position_form", $form_id, $form_type);
+ $rtn .= drupal_render($arrange_fields_position_form);
richardp’s picture

Version: 7.x-1.1 » 7.x-1.11
Status: Needs work » Fixed

Sorry for the very late reply, but I believe this was fixed in a recent version, so I am marking the issue fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.