Download & Extend

node_page_edit doc has wrong information

Project:Drupal core
Version:8.x-dev
Component:documentation
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7

Issue Summary

API page: http://api.drupal.org/api/drupal/modules--node--node.pages.inc/function/...

Describe the problem you have found:

> Menu callback; presents the node editing form, or redirects to delete confirmation.

I don't think this function does the 'redirects to delete confirmation' part.

Comments

#1

Component:node.module» documentation
Status:active» needs review

You're right. While it will pass through node_page_edit again on the way to delete confirmation, the logic isn't in this function.

Similar functions, such as user_profile_form, do not have this comment even though they function in the same way, so it makes sense to remove the comment.

AttachmentSizeStatusTest resultOperations
1236594-01-node_page_edit-comment.patch415 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 33,642 pass(es).View details

#2

Title:Documentation problem with node_page_edit» node_page_edit doc has wrong information
Status:needs review» reviewed & tested by the community

Patch is OK for 7.x/8.x. We need to make some standards for menu callback docs... I think there was an issue that never was resolved. Sigh. They're all over the map currently, but no reason to hold this correction up.

#3

Status:reviewed & tested by the community» fixed

Committed to 7.x and 8.x. Thanks!

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here