It looks like the recent backport for drush support in http://drupalcode.org/project/uuid.git/commit/3e5634275f0fd7e6d623a71cb3... calls the uuid_sync function and added a default argument of $types = NULL to that function.
This function is actually already used as a submit handler by the admin form so the types variable is getting set as the form object. This means that the update of uuids for nodes fails.
I've attached a patch which provides a new submit function as a wrapper to get around the argument issues.

CommentFileSizeAuthor
#7 uuidsyncsubmit-1236768-7-d6.patch661 bytesdave_robinson
syncsubmitfunc-xxx-0-d6.patch638 bytesdave_robinson

Comments

Offlein’s picture

Offlein commented
Priority: Normal » Critical
Status: Active » Reviewed & tested by the community

I would consider this issue critical since it essentially means that UUIDs are not generated for new people installing UUID. Like me. I had to really do some research to figure this out.

FWIW, the Drush command generates properly Node UUIDs as well.

jgraham’s picture

jgraham commented

Just wanted to chime in that the patch works for me.

btopro’s picture

btopro commented

I don't understand why there's a difference but I can also confirm that this worked. +1 for commit

recidive’s picture

recidive commented
Status: Reviewed & tested by the community » Needs work

I think we should add the standard form arguments to the callback like this: uuid_sync_submit($form, &$form_state). Also, comment on this function should be fixed.

webadpro’s picture

webadpro commented
Status: Needs work » Reviewed & tested by the community

Please commit this patch.

recidive’s picture

recidive commented
Status: Reviewed & tested by the community » Needs work

The patch is not finished yet. If you want this committed, please make the changes I've requested in #4 and test them.

dave_robinson’s picture

dave_robinson commented
Status: Needs work » Needs review
StatusFileSize
new uuidsyncsubmit-1236768-7-d6.patch661 bytes

I've added the form args, fixed the comment and rerolled the attached patch against the latest git.

apotek’s picture

apotek commented

This looks like a good patch. What do we need to set so the patch can be run against tests?

greg.1.anderson’s picture

greg.1.anderson commented
Status: Needs review » Reviewed & tested by the community

Tested the patch, and it works well. The "Create missing UUIDs" does nothing in 6.x-1.x-dev without this patch, and it creates the missing UUIDs correctly with it applied. Is there anything else that needs to be done here? This is a blocking issue for the beta3 release.

c.f. #1149546: Please release 6.x-beta3, as it is not possible to upgrade to Drupal-7.x if uuid-6.x-beta2 is installed

pdrake’s picture

pdrake commented

Works great for me. RTBC

hongpong’s picture

hongpong commented

for what it's worth, when using 6.x-1.0-beta2+14 i was NOT able to generate about 2000 Node UUIDs and node revision UUIDs via the web interface but fortunately the drush command got those created.

skwashd’s picture

skwashd commented

Sorry for the delay in applying this patch. It has been committed (02deb07) and will be included in the next release.

skwashd’s picture

skwashd commented
Status: Reviewed & tested by the community » Fixed

Fixing status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.