due to incorrect entry naming, error information from the nuSoap library is not copied into the $result variable, leading to non-informative watchdog log messages (by modules using the soapclient module)

file: drupal_soap_client.inc
class: DrupalSoapClient
method: call

        $result['#error'] = t('Fault !code: !msg', array( '!code' => $result['return']['faultcode'], '!msg' => $result['return']['faultstring'] ));

Should be:

        $result['#error'] = t('Fault !code: !msg', array( '!code' => $result['#return']['faultcode'], '!msg' => $result['#return']['faultstring'] ));

Comments

13rac1’s picture

13rac1 commented
Status: Needs review » Postponed (maintainer needs more info)

Set to Needs Review, only when a patch is attached.

This seems fixed in the current dev? Which line number is the problem at?

      if ( is_soap_fault($result['#return']) ) {
        $result['#error'] = t('Fault !code: !msg', array( '!code' => $result['#return']->faultcode, '!msg' => $result['#return']->faultstring ));
        return $result;
      }
13rac1’s picture

13rac1 commented
Issue summary: View changes

added file