This fasttoggle module is terribly annoying :) If we can't limit's behavior it to the content type we care about (sponsor) then we shouldn't make it a requirement for the sponsor feature.

CommentFileSizeAuthor
#7 cod_remove_fasttoggle.patch313 bytesgreggles
#7 cod_support_remove_fasttoggle.patch9.2 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Postponed

Disagree.

(See what I did there? I stated an opinion without the specific pros/cons. It was probably hard to argue with my claim. *ahem*)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Postponed » Postponed (maintainer needs more info)
jenlampton’s picture

jenlampton
she / her
commented

My use case is that sponsors are not creating their own nodes.

I don't need fast toggle at all because we're manually creating sponsorships, and will publish them ourselves. We're not using the admin approval view. With fast toggle on, every node seen in teaser mode has toggles for stuff like sticky and promoted to home, a minor annoyance, agreed, but a totally unnecessary one.

I think this module, instead of being "required" should really be optional, and enabled by default so the platform can be more flexible. :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: remove fasttoggle requirement » Set fasttoggle to be less obtrusive on teaser links
Status: Postponed (maintainer needs more info) » Active

Cool. How about some more sensible defaults for the module?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Set fasttoggle to be less obtrusive on teaser links » Remove dependency on fasttoggle

Actually, this seems reasonable.

jenlampton’s picture

jenlampton
she / her
commented

Woot :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new cod_support_remove_fasttoggle.patch9.2 KB
new cod_remove_fasttoggle.patch313 bytes

I think this is it?

Note that one of these is for cod_support's cod_sponsors.

I'm tempted to "won't fix" this if it is more complex than this change. Just because the focus for 6.x is on getting it out the door as a 1.0 and this seems like a low priority item.

Edited to add justification for last sentence.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Closed (won't fix)

This no longer applies and without a review and with 6.x-1.0 on the doorstep it seems like won't fix is the best answer.

Seems fine to me to revive it if someone wants to provide a patch.