Drupal 5 update
christefanø - March 1, 2007 - 09:38
| Project: | OpenSearch Feed |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | critical |
| Assigned: | ŐRY Máté |
| Status: | closed |
Description
This excellent module needs a .info file to work with Drupal 5. I created one and opensearch works on all my Drupal 5.1 sites, so I'm attaching it here. Remove .txt from the filename.
Thank you for this module.
| Attachment | Size |
|---|---|
| opensearch.info_.txt | 434 bytes |
#1
#2
#3
Added an updated .info file which doesn't include all the bits that drupal.org will add automatically. It'd be great to see a 5.x release of this module.
#4
Thanks. I created this issue before I knew how $Id$ tags worked.
#5
t()tokens changed → invalid XML description fileI'm working on the patch.
#6
Some work on Drupal 5 compatibility. The channel is still not recognized by ff3. Patch for #250449: OS description file ignores clean_url included.
#7
5_.diff says it's for opensearch.module 1.5 but it doesn't apply at all.
#8
$ wget http://drupal.org/files/issues/5_.diff$ wget http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/opensearch/opensearch.module?revision=1.5
$ patch -p0 < 5_.diff
Works for me on Ubuntu 8.04.
#9
#10
Viewing the OpenSearch feed only shows the front page of the Drupal site and viewing the OpenSearch Feed settings page throws an error:
Fatal error: Cannot use string offset as an array in /var/www/modules/system/system.module on line 1077Thank you for your recent efforts! I'm not using OpenSearch Feed much anymore since Faceted Search has come on the scene, so I won't really be able to test any further.
#11
Mostly coder spacing fixes.
Also fixed function opensearch_menu for 'admin/settings/opensearch' to resolve #10
- 'callback' => 'opensearch_admin_settings',+ 'callback' => 'drupal_get_form',
+ 'callback arguments' => array('opensearch_admin_settings'),
#12
Added site name to auto-discovery title
- 'title' => $opensearch_shortname+ 'title' => variable_get('site_name', 'Drupal') . ' ' . $opensearch_shortname
#13
#14
DRUPAL-5 branch created, dev release available here:
http://drupal.org/node/295874
#15
Automatically closed -- issue fixed for two weeks with no activity.