Hi, I discovered that the drupal_goto calls in the module are interfering with cron. I've added the following change to check for cron before redirecting to fix that. (see attached patch)

CommentFileSizeAuthor
#3 1238214.patch620 bytesjimbullington
webform_goto_cron_patch.patch938 bytesthesleuth

Comments

zanix’s picture

zanix
Primary language English
commented

Applying the patch had errors

Checking patch webform_report.module...
error: while searching for:
 * Implementation of hook_view
 */
function webform_report_view($node, $teaser = FALSE, $page = FALSE) {
  if(!empty($node->nid) && empty($node->wnid) && (arg(2) != 'add' && arg(2) != 'edit')) {
    drupal_goto('node/' . $node->nid . '/add/webform_report/criteria');
  }
  module_load_include('inc', 'webform_report', 'webform_report');

error: patch failed: webform_report.module:199
error: webform_report.module: patch does not apply
zanix’s picture

zanix
Primary language English
commented

That line will not prevent cron ran from Drupal itself
admin/reports/status/run-cron

Try this

  if (!empty($node->nid) && empty($node->wnid) && (arg(2) != 'add' && arg(2) != 'edit') && !preg_match("/(?:cron.php|run-cron)/", $_SERVER['REQUEST_URI'])) {
jimbullington’s picture

jimbullington commented
Status: Active » Needs review
StatusFileSize
new 1238214.patch620 bytes

The module seems to work OK without the drupal_goto() - try the attached patch.