the version of css-compressor included in this module incorrectly removes quotes from string attribute selectors which will cause them to be ignored by browsers.

i reported this to the maintainer of css-compressor and a fix has been committed. see https://github.com/codenothing/css-compressor/commit/9168794b3de124f5276...

but there are apparently no plans for a new release soon. i don't know if it makes sense to patch the version included or just keep an eye out for a new release.

css-tidy does not have this flaw, so using it is a work around if this affects your css.

CommentFileSizeAuthor
#1 advagg-1238432-1.patch2.45 KBmikeytown2

Comments

mikeytown2’s picture

Version: 6.x-1.4 » 6.x-1.x-dev
Status: Active » Fixed
StatusFileSize
new2.45 KB

Thanks for putting the bug in the correct place.

I've applied these 2 commits
https://github.com/codenothing/css-compressor/commit/f1ad86cd4862ebccd4d...
https://github.com/codenothing/css-compressor/commit/9168794b3de124f5276...

Attached is the patch that was committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.