Conditional HTML tags missing closing brackets [#1238596]

Nice theme, I'm creating a very similar HTML5 base theme based off of Boron and using bits and pieces from HTML5 Boilerplate and other sources.

I noticed in your html.tpl.php that your conditional HTML tags for IE are missing closing brackets (after the class attribute).

<?php $html_tag_attrs = "xml:lang=\"{$language->language}\" dir=\"{$language->dir}\" {$rdf->version}{$rdf->namespaces}";?>
<!-- If you don't care about older browsers remove the following declarations -->
<!-- paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/ -->
<!--[if lt IE 7 ]> <html <?php print $html_tag_attrs;?> class="no-js ie6" <![endif]-->
<!--[if IE 7 ]> <html <?php print $html_tag_attrs;?> class="no-js ie7" <![endif]-->
<!--[if IE 8 ]> <html <?php print $html_tag_attrs;?> class="no-js ie8" <![endif]-->
<!--[if IE 9 ]> <html <?php print $html_tag_attrs;?> class="no-js ie9" <![endif]-->
<!--[if (gt IE 9)|!(IE)]><!--> <html <?php print $html_tag_attrs;?> class="no-js"> <!--<![endif]-->

Also, I believe lang should be used instead of xml:lang on the HTML tag.

Comment	File	Size	Author
#1	1238596.patch	1.43 KB	migueltrindade

Comments

Comment #1

migueltrindade commented 8 August 2011 at 18:53

Status	File	Size
new	1238596.patch	1.43 KB

Hi Cottser.
First of all, I'm the new co-maintainer for zentropy and i'll try to fix some issues.
Thanks for your comment. We'll fix this on the next release.
Here is a patch: http://drupal.org/files/1238596.patch