By default Drupal allows title length up to 255 characters.

In the database, that is the length for the product title and node title fields.

However, the commerce_bpc module doesn't set a 'maxlength' property on the form element to set the title, thus it defaults to 128 which is too short when including a bunch of field tokens in the title.

The attached patch fixes the issue and brings the title field up to 255 characters, the Drupal standard title length.

Thanks for the useful module.

DT

CommentFileSizeAuthor
commerce_bpc.forms_.inc_.title-maxlength.patch445 bytesdavidwhthomas

Comments

sven.lauer’s picture

sven.lauer commented
Status: Needs review » Fixed

Nice catch. I'll apply this for now, even though one might even want to set a larger maxlength, as the token names can easily be longer than their values.

Anyhow, the need to enter tokens for every field will go away shortly, so maybe for the future this is a moot point.

http://drupalcode.org/project/commerce_bpc.git/commit/7e788a5

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.