These *can* be escaped with ` in queries, but it's just asking for trouble to use reserved words.

This also blocks #1239074: use drupal_write_record() to save log item.

CommentFileSizeAuthor
#3 1239398-3.mail_logger.mysql-reserved-keywords.patch5.4 KBjoachim
#2 1239398-2.mail_logger.mysql-reserved-keywords.patch4.28 KBjoachim
#1 1239398.mail_logger.mysql-reserved-keywords.patch2.83 KBjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1239398.mail_logger.mysql-reserved-keywords.patch2.83 KB

This patch renames the 'to' and 'from' columns.

It also results in Schema module no longer reporting a mismatch, so marking #825042: Schema module always reports schema miss-matching tables error as a duplicate.

joachim’s picture

joachim commented
StatusFileSize
new 1239398-2.mail_logger.mysql-reserved-keywords.patch4.28 KB

Oops. Missed some column names in the module. Here's an updated patch.

joachim’s picture

joachim commented
StatusFileSize
new 1239398-3.mail_logger.mysql-reserved-keywords.patch5.4 KB

*sigh*... and some more...

ermannob’s picture

ermannob commented

I agree with this.
Tried that patch and it works.

Thanks joachim.
-ermannob

fizk’s picture

fizk commented
Issue summary: View changes
Status: Needs review » Fixed

Fixed, thanks!

  • Commit cf005dd on 6.x-1.x authored by joachim, committed by fizk: 
    #1239398 joachim: Avoid using MySQL reserved words for column names.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.