Closed (fixed)
Project:
ISBN Field
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2011 at 19:32 UTC
Updated:
26 Sep 2012 at 02:21 UTC
The widget setting to Not Validate does not work. The reason is this line of code that checks if validation should be done or not:
having the !-- check not just logic but data type as well... and the field setting comes in as a string '0', '1' or '2'.. whereas the constant is a long int.. so this fails all the time
correct code should be
$field['isbn_validation'] != ISBN_NO_VALIDATION
patch is attached
| Comment | File | Size | Author |
|---|---|---|---|
| isbn-fix_no_validate.patch | 688 bytes | liquidcms |
Comments
Comment #1
jon pughApplied and fixed in 6.x-1.x! Thanks.
http://drupalcode.org/project/isbn.git/commit/ffee7bd
Don't forget, we are looking for a maintainer!